h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-28 09:37:23 +08:00
Code Issues Releases Wiki Activity

Add transactional committing of scores/beatmaps

Browse Source 
This helps slightly with performance, allows better monitoring via realm
studio, but most importantly greatly reduces filesize.

fully compacted:        109M
transaction size 100:   115M
transaction size 1000:  123M
transaction size 10000: 164M
single transaction:     183M

With a transaction size of 100 there is a performance reduction, so 1000
seems to be the best middle-ground.
This commit is contained in:
Dean Herbert 2022-01-19 16:01:17 +09:00
parent 973836484c
commit 42736c9995
1 changed files with 34 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
osu.Game/Database/EFToRealmMigrator.cs
View File

@ -94,10 +94,20 @@ namespace osu.Game.Database
} }
else else
{ {
using (var transaction = realm.BeginWrite()) var transaction = realm.BeginWrite();
int written = 0;
try
{ {
foreach (var beatmapSet in existingBeatmapSets) foreach (var beatmapSet in existingBeatmapSets)
{ {
if (++written % 1000 == 0)
{
transaction.Commit();
transaction = realm.BeginWrite();
Logger.Log($"Migrated {written}/{count} beatmaps...", LoggingTarget.Database);
}
var realmBeatmapSet = new BeatmapSetInfo var realmBeatmapSet = new BeatmapSetInfo
{ {
OnlineID = beatmapSet.OnlineID ?? -1, OnlineID = beatmapSet.OnlineID ?? -1,
@ -149,10 +159,13 @@ namespace osu.Game.Database
realm.Add(realmBeatmapSet); realm.Add(realmBeatmapSet);
} }
transaction.Commit();
Logger.Log($"Successfully migrated {count} beatmaps to realm", LoggingTarget.Database);
} }
finally
{
transaction.Commit();
}
Logger.Log($"Successfully migrated {count} beatmaps to realm", LoggingTarget.Database);
} }
} }
} }
@ -221,10 +234,20 @@ namespace osu.Game.Database
} }
else else
{ {
using (var transaction = realm.BeginWrite()) var transaction = realm.BeginWrite();
int written = 0;
try
{ {
foreach (var score in existingScores) foreach (var score in existingScores)
{ {
if (++written % 1000 == 0)
{
transaction.Commit();
transaction = realm.BeginWrite();
Logger.Log($"Migrated {written}/{count} scores...", LoggingTarget.Database);
}
var realmScore = new ScoreInfo var realmScore = new ScoreInfo
{ {
Hash = score.Hash, Hash = score.Hash,
@ -255,10 +278,13 @@ namespace osu.Game.Database
realm.Add(realmScore); realm.Add(realmScore);
} }
transaction.Commit();
Logger.Log($"Successfully migrated {count} scores to realm", LoggingTarget.Database);
} }
finally
{
transaction.Commit();
}
Logger.Log($"Successfully migrated {count} scores to realm", LoggingTarget.Database);
} }
} }
} }