h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 06:43:21 +08:00
Code Issues Releases Wiki Activity

Merge pull request #10271 from peppy/editor-fix-unnecessary-updates

Browse Source 
Avoid unnecessary object updates from SelectionHandlers
This commit is contained in:
Dan Balasescu 2020-09-28 16:13:26 +09:00 committed by GitHub
commit 3fd8830f5b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game.Rulesets.Taiko/Edit/TaikoSelectionHandler.cs
View File

@ -57,7 +57,13 @@ namespace osu.Game.Rulesets.Taiko.Edit
ChangeHandler.BeginChange(); ChangeHandler.BeginChange();
foreach (var h in hits) foreach (var h in hits)
h.IsStrong = state; {
if (h.IsStrong != state)
{
h.IsStrong = state;
EditorBeatmap.UpdateHitObject(h);
}
}
ChangeHandler.EndChange(); ChangeHandler.EndChange();
} }

3
osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs
View File

@ -288,8 +288,7 @@ namespace osu.Game.Screens.Edit.Compose.Components
{ {
var comboInfo = h as IHasComboInformation; var comboInfo = h as IHasComboInformation;
if (comboInfo == null) if (comboInfo == null || comboInfo.NewCombo == state) continue;
continue;
comboInfo.NewCombo = state; comboInfo.NewCombo = state;
EditorBeatmap?.UpdateHitObject(h); EditorBeatmap?.UpdateHitObject(h);