h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-13 10:33:07 +08:00
Code Issues Releases Wiki Activity

Fix incorrect spinner top offset calculation with clarification

Browse Source
This commit is contained in:
Salman Ahmed 2021-03-11 05:40:18 +03:00
parent 0549395869
commit 3f34981664
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osu.Game.Rulesets.Osu/Skinning/Legacy/LegacySpinner.cs
View File

@ -9,6 +9,7 @@ using osu.Framework.Graphics.Containers;
using osu.Framework.Graphics.Sprites;
using osu.Game.Rulesets.Objects.Drawables;
using osu.Game.Rulesets.Osu.Objects.Drawables;
using osu.Game.Rulesets.Osu.UI;
using osu.Game.Skinning;
using osuTK;
@ -16,7 +17,13 @@ namespace osu.Game.Rulesets.Osu.Skinning.Legacy
{
public abstract class LegacySpinner : CompositeDrawable
{
protected static readonly float SPINNER_TOP_OFFSET = MathF.Ceiling(45f * SPRITE_SCALE);
/// <remarks>
/// osu!stable applies this adjustment conditionally, locally in the spinner.
/// in lazer this is handled at a higher level in <see cref="OsuPlayfieldAdjustmentContainer"/>,
/// therefore it's safe to apply it unconditionally in this component.
/// </remarks>
protected static readonly float SPINNER_TOP_OFFSET = 45f - 16f;
protected static readonly float SPINNER_Y_CENTRE = SPINNER_TOP_OFFSET + 219f;
protected const float SPRITE_SCALE = 0.625f;