From 3f2ba893ba4bc37c718d0b77dbdc557f7f83a3b9 Mon Sep 17 00:00:00 2001
From: Salman Alshamrani <frenzibyte@gmail.com>
Date: Wed, 21 May 2025 15:36:11 +0300
Subject: [PATCH] Fix "no results" placeholder having weird transitions

---
 osu.Game/Screens/SelectV2/SongSelect.cs | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/osu.Game/Screens/SelectV2/SongSelect.cs b/osu.Game/Screens/SelectV2/SongSelect.cs
index 61d079410f..9717a4c124 100644
--- a/osu.Game/Screens/SelectV2/SongSelect.cs
+++ b/osu.Game/Screens/SelectV2/SongSelect.cs
@@ -346,7 +346,6 @@ namespace osu.Game.Screens.SelectV2
             filterDebounce?.Cancel();
             filterDebounce = Scheduler.AddDelayed(() =>
             {
-                noResultsPlaceholder.Filter = criteria;
                 carousel.Filter(criteria);
             }, filter_delay);
         }
@@ -355,7 +354,13 @@ namespace osu.Game.Screens.SelectV2
         {
             int count = carousel.MatchedBeatmapsCount;
 
-            noResultsPlaceholder.State.Value = count == 0 ? Visibility.Visible : Visibility.Hidden;
+            if (count == 0)
+            {
+                noResultsPlaceholder.Show();
+                noResultsPlaceholder.Filter = carousel.Criteria;
+            }
+            else
+                noResultsPlaceholder.Hide();
 
             // Intentionally not localised until we have proper support for this (see https://github.com/ppy/osu-framework/pull/4918
             // but also in this case we want support for formatting a number within a string).