diff --git a/osu.Game.Tests/Visual/Online/TestSceneBeatmapSetOverlay.cs b/osu.Game.Tests/Visual/Online/TestSceneBeatmapSetOverlay.cs index f36ef7a8e8..5da05826cf 100644 --- a/osu.Game.Tests/Visual/Online/TestSceneBeatmapSetOverlay.cs +++ b/osu.Game.Tests/Visual/Online/TestSceneBeatmapSetOverlay.cs @@ -10,6 +10,8 @@ using osu.Game.Rulesets; using System; using System.Collections.Generic; using System.Linq; +using Newtonsoft.Json; +using Newtonsoft.Json.Linq; using osu.Framework.Testing; using osu.Game.Beatmaps.Drawables; using osu.Game.Graphics.Sprites; @@ -193,7 +195,8 @@ namespace osu.Game.Tests.Visual.Online overlay.ShowBeatmapSet(set); }); - AddAssert("shown beatmaps of current ruleset", () => overlay.Header.HeaderContent.Picker.Difficulties.All(b => b.Beatmap.Ruleset.OnlineID == overlay.Header.RulesetSelector.Current.Value.OnlineID)); + AddAssert("shown beatmaps of current ruleset", + () => overlay.Header.HeaderContent.Picker.Difficulties.All(b => b.Beatmap.Ruleset.OnlineID == overlay.Header.RulesetSelector.Current.Value.OnlineID)); AddAssert("left-most beatmap selected", () => overlay.Header.HeaderContent.Picker.Difficulties.First().State == BeatmapPicker.DifficultySelectorState.Selected); } @@ -373,6 +376,39 @@ namespace osu.Game.Tests.Visual.Online }); } + [Test] + public void TestBeatmapsetWithDeletedUser() + { + AddStep("show map with deleted user", () => + { + JObject jsonBlob = JObject.FromObject(getBeatmapSet(), new JsonSerializer + { + ReferenceLoopHandling = ReferenceLoopHandling.Ignore + }); + + jsonBlob["user"] = JToken.Parse( + """ + { + "avatar_url": null, + "country_code": null, + "default_group": "default", + "id": null, + "is_active": false, + "is_bot": false, + "is_deleted": true, + "is_online": false, + "is_supporter": false, + "last_visit": null, + "pm_friends_only": false, + "profile_colour": null, + "username": "[deleted user]" + } + """); + + overlay.ShowBeatmapSet(JsonConvert.DeserializeObject(JsonConvert.SerializeObject(jsonBlob))); + }); + } + private APIBeatmapSet createManyDifficultiesBeatmapSet() { var set = getBeatmapSet(); diff --git a/osu.Game/Online/API/Requests/Responses/APIBeatmapSet.cs b/osu.Game/Online/API/Requests/Responses/APIBeatmapSet.cs index e8e08059b9..dc6c433f29 100644 --- a/osu.Game/Online/API/Requests/Responses/APIBeatmapSet.cs +++ b/osu.Game/Online/API/Requests/Responses/APIBeatmapSet.cs @@ -84,11 +84,26 @@ namespace osu.Game.Online.API.Requests.Responses /// The creator of this beatmap set. /// /// - /// This is not included when the set is retrieved via , - /// but the creator's ID and username will be filled in this property from the and properties. + /// This property is set differently depending on the API endpoint. When retrieved via , + /// detailed user info is not included and the creator's ID and username are filled from the and + /// properties. For other API endpoints, this property is set by the setter. + /// + public APIUser Author = new APIUser(); + + /// + /// Helper property to deserialize the detailed user info to + /// + /// + /// This setter implements special handling for deleted users. When received a user with ID 1, it indicates + /// the original user has been deleted. In such cases, the existing data + /// (filled from and ) is preserved. For valid user, + /// the provided user info replaces the existing . /// [JsonProperty(@"user")] - public APIUser Author = new APIUser(); + private APIUser author + { + set => Author = value.Id != 1 ? value : Author; + } /// /// The ID of the beatmap set's creator.