h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-28 09:43:10 +08:00
Code Issues Releases Wiki Activity

Simplify verifier run call args

Browse Source 
Uses the resolved working beatmap instead of resolving it every time.

Also uses the EditorBeatmap itself as playable beatmap, as it is of type `IBeatmap` already, and `.PlayableBeatmap` forwards everything anyway.
This commit is contained in:
Naxess 2021-04-20 13:34:12 +02:00
parent c0318a4d3e
commit 3e1b6b3b34
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Screens/Edit/Verify/VerifyScreen.cs
View File

@ -61,7 +61,7 @@ namespace osu.Game.Screens.Edit.Verify
private EditorClock clock { get; set; } private EditorClock clock { get; set; }
[Resolved] [Resolved]
private BeatmapManager beatmapManager { get; set; } private IBindable<WorkingBeatmap> workingBeatmap { get; set; }
[Resolved] [Resolved]
private EditorBeatmap beatmap { get; set; } private EditorBeatmap beatmap { get; set; }
@ -122,11 +122,10 @@ namespace osu.Game.Screens.Edit.Verify
private void refresh() private void refresh()
{ {
var workingBeatmap = beatmapManager.GetWorkingBeatmap(beatmap.BeatmapInfo); var issues = generalVerifier.Run(beatmap, workingBeatmap.Value);
var issues = generalVerifier.Run(beatmap.PlayableBeatmap, workingBeatmap);
if (rulesetVerifier != null) if (rulesetVerifier != null)
issues = issues.Concat(rulesetVerifier.Run(beatmap.PlayableBeatmap, workingBeatmap)); issues = issues.Concat(rulesetVerifier.Run(beatmap, workingBeatmap.Value));
table.Issues = issues table.Issues = issues
.OrderBy(issue => issue.Template.Type) .OrderBy(issue => issue.Template.Type)