h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 12:23:22 +08:00
Code Issues Releases Wiki Activity

Replace iterated addition with rounding

Browse Source
This commit is contained in:
Bartłomiej Dach 2020-06-30 20:16:19 +02:00
parent 1551c42c12
commit 39cfbb67ad
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game.Rulesets.Mania/Beatmaps/Patterns/Legacy/DistanceObjectPatternGenerator.cs
View File

@ -483,12 +483,8 @@ namespace osu.Game.Rulesets.Mania.Beatmaps.Patterns.Legacy
if (!(HitObject is IHasPathWithRepeats curveData)) if (!(HitObject is IHasPathWithRepeats curveData))
return null; return null;
// mathematically speaking this could be done by calculating (time - HitObject.StartTime) / SegmentDuration // mathematically speaking this should be a whole number always, but floating-point arithmetic is not so kind
// however, floating-point operations can introduce inaccuracies - therefore resort to iterated addition var index = (int)Math.Round(SegmentDuration == 0 ? 0 : (time - HitObject.StartTime) / SegmentDuration, MidpointRounding.AwayFromZero);
// (all callers use this method to calculate repeat point times, so this way is consistent and deterministic)
int index = 0;
for (double nodeTime = HitObject.StartTime; nodeTime < time; nodeTime += SegmentDuration)
index += 1;
// avoid slicing the list & creating copies, if at all possible. // avoid slicing the list & creating copies, if at all possible.
return index == 0 ? curveData.NodeSamples : curveData.NodeSamples.Skip(index).ToList(); return index == 0 ? curveData.NodeSamples : curveData.NodeSamples.Skip(index).ToList();