h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-21 18:42:56 +08:00
Code Issues Releases Wiki Activity

Ensure variable isolation over multiple test runs

Browse Source
This commit is contained in:
Dean Herbert 2019-02-19 13:58:05 +09:00
parent 6b81315009
commit 39b203375f
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
osu.Game.Rulesets.Osu.Tests/TestCaseSliderInput.cs
View File

@ -308,6 +308,8 @@ namespace osu.Game.Rulesets.Osu.Tests
private bool assertMidSliderJudgementFail() => judgementResults[judgementResults.Count - 2].Type == HitResult.Miss; private bool assertMidSliderJudgementFail() => judgementResults[judgementResults.Count - 2].Type == HitResult.Miss;
private ScoreAccessibleReplayPlayer currentPlayer;
private void performTest(List<ReplayFrame> frames) private void performTest(List<ReplayFrame> frames)
{ {
// Empty frame to be added as a workaround for first frame behavior. // Empty frame to be added as a workaround for first frame behavior.
@ -324,17 +326,23 @@ namespace osu.Game.Rulesets.Osu.Tests
p.OnLoadComplete += _ => p.OnLoadComplete += _ =>
{ {
p.ScoreProcessor.NewJudgement += result => judgementResults.Add(result); p.ScoreProcessor.NewJudgement += result =>
p.ScoreProcessor.AllJudged += () => { allJudgedFired = true; }; {
if (currentPlayer == p) judgementResults.Add(result);
};
p.ScoreProcessor.AllJudged += () =>
{
if (currentPlayer == p) allJudgedFired = true;
};
}; };
AddStep("load player", () => LoadScreen(p)); AddStep("load player", () =>
AddUntilStep(() => p.IsLoaded, "Wait until player is loaded");
AddStep("reset counts", () =>
{ {
LoadScreen(currentPlayer = p);
allJudgedFired = false; allJudgedFired = false;
judgementResults = new List<JudgementResult>(); judgementResults = new List<JudgementResult>();
}); });
AddUntilStep(() => p.IsLoaded, "Wait until player is loaded");
AddUntilStep(() => allJudgedFired, "Wait for all judged"); AddUntilStep(() => allJudgedFired, "Wait for all judged");
} }