h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-07 21:23:22 +08:00
Code Issues Releases Wiki Activity

Add failing test showing deserialise failing with some skins

Browse Source
This commit is contained in:
Dean Herbert 2024-08-23 20:44:35 +09:00
parent 1e39af8ac5
commit 3943fe96f4
No known key found for this signature in database
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
osu.Game.Tests/Resources/Archives/argon-invalid-drawable.osk Normal file
View File

Binary file not shown.

13
osu.Game.Tests/Skins/SkinDeserialisationTest.cs
View File

@ -12,6 +12,7 @@ using osu.Framework.IO.Stores;
using osu.Game.Audio; using osu.Game.Audio;
using osu.Game.IO; using osu.Game.IO;
using osu.Game.IO.Archives; using osu.Game.IO.Archives;
using osu.Game.Screens.Menu;
using osu.Game.Screens.Play.HUD; using osu.Game.Screens.Play.HUD;
using osu.Game.Screens.Play.HUD.HitErrorMeters; using osu.Game.Screens.Play.HUD.HitErrorMeters;
using osu.Game.Skinning; using osu.Game.Skinning;
@ -125,6 +126,18 @@ namespace osu.Game.Tests.Skins
} }
} }
[Test]
public void TestDeserialiseInvalidDrawables()
{
using (var stream = TestResources.OpenResource("Archives/argon-invalid-drawable.osk"))
using (var storage = new ZipArchiveReader(stream))
{
var skin = new TestSkin(new SkinInfo(), null, storage);
Assert.That(skin.LayoutInfos.Any(kvp => kvp.Value.AllDrawables.Any(d => d.Type == typeof(StarFountain))), Is.False);
}
}
[Test] [Test]
public void TestDeserialiseModifiedClassic() public void TestDeserialiseModifiedClassic()
{ {