h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 05:32:54 +08:00
Code Issues Releases Wiki Activity

Check if the current leaderboard scope requires API (#5415)

Browse Source 
Check if the current leaderboard scope requires API

Co-authored-by: Dean Herbert <pe@ppy.sh>
This commit is contained in:
Dean Herbert 2019-07-21 15:48:00 +09:00 committed by GitHub
commit 38d39be678
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Online/Leaderboards/Leaderboard.cs
View File

@ -194,13 +194,17 @@ namespace osu.Game.Online.Leaderboards
private APIRequest getScoresRequest; private APIRequest getScoresRequest;
protected abstract bool IsOnlineScope { get; }
public void APIStateChanged(IAPIProvider api, APIState state) public void APIStateChanged(IAPIProvider api, APIState state)
{ {
switch (state) switch (state)
{ {
case APIState.Online: case APIState.Online:
case APIState.Offline: case APIState.Offline:
UpdateScores(); if (IsOnlineScope)
UpdateScores();
break; break;
} }
} }

2
osu.Game/Screens/Multi/Match/Components/MatchLeaderboard.cs
View File

@ -33,6 +33,8 @@ namespace osu.Game.Screens.Multi.Match.Components
}, true); }, true);
} }
protected override bool IsOnlineScope => true;
protected override APIRequest FetchScores(Action<IEnumerable<APIRoomScoreInfo>> scoresCallback) protected override APIRequest FetchScores(Action<IEnumerable<APIRoomScoreInfo>> scoresCallback)
{ {
if (roomId.Value == null) if (roomId.Value == null)

2
osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs
View File

@ -79,6 +79,8 @@ namespace osu.Game.Screens.Select.Leaderboards
}; };
} }
protected override bool IsOnlineScope => Scope != BeatmapLeaderboardScope.Local;
protected override APIRequest FetchScores(Action<IEnumerable<ScoreInfo>> scoresCallback) protected override APIRequest FetchScores(Action<IEnumerable<ScoreInfo>> scoresCallback)
{ {
if (Scope == BeatmapLeaderboardScope.Local) if (Scope == BeatmapLeaderboardScope.Local)