From 13425568945c4bde5c130266b2ff19156f867fef Mon Sep 17 00:00:00 2001 From: Joehu Date: Sun, 15 Dec 2019 08:34:57 -0800 Subject: [PATCH 1/3] Allow ctrl tabbing navigation to chat and song select leaderboards --- osu.Game/Overlays/ChatOverlay.cs | 1 + osu.Game/Screens/Select/BeatmapDetailAreaTabControl.cs | 1 + 2 files changed, 2 insertions(+) diff --git a/osu.Game/Overlays/ChatOverlay.cs b/osu.Game/Overlays/ChatOverlay.cs index 33bcc4c139..08043a097b 100644 --- a/osu.Game/Overlays/ChatOverlay.cs +++ b/osu.Game/Overlays/ChatOverlay.cs @@ -171,6 +171,7 @@ namespace osu.Game.Overlays d.Origin = Anchor.BottomLeft; d.RelativeSizeAxes = Axes.Both; d.OnRequestLeave = channelManager.LeaveChannel; + d.Tabbable = true; }), } }, diff --git a/osu.Game/Screens/Select/BeatmapDetailAreaTabControl.cs b/osu.Game/Screens/Select/BeatmapDetailAreaTabControl.cs index 433e8ee398..a6933b478e 100644 --- a/osu.Game/Screens/Select/BeatmapDetailAreaTabControl.cs +++ b/osu.Game/Screens/Select/BeatmapDetailAreaTabControl.cs @@ -48,6 +48,7 @@ namespace osu.Game.Screens.Select Anchor = Anchor.BottomLeft, Origin = Anchor.BottomLeft, RelativeSizeAxes = Axes.Both, + Tabbable = true, }, }, modsCheckbox = new OsuTabControlCheckbox From 119b48ccb0e77e8ed35c3e2537b2dc1fb51b4d2d Mon Sep 17 00:00:00 2001 From: Joehu Date: Sun, 15 Dec 2019 08:35:38 -0800 Subject: [PATCH 2/3] Remove redundant tab item override --- osu.Game/Graphics/UserInterface/BreadcrumbControl.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/osu.Game/Graphics/UserInterface/BreadcrumbControl.cs b/osu.Game/Graphics/UserInterface/BreadcrumbControl.cs index d1e55fee24..93ea6bbbe6 100644 --- a/osu.Game/Graphics/UserInterface/BreadcrumbControl.cs +++ b/osu.Game/Graphics/UserInterface/BreadcrumbControl.cs @@ -52,7 +52,6 @@ namespace osu.Game.Graphics.UserInterface public override bool HandleNonPositionalInput => State == Visibility.Visible; public override bool HandlePositionalInput => State == Visibility.Visible; - public override bool IsRemovable => true; private Visibility state; From b038c192d12df09206f072214c2e20959dd4fe09 Mon Sep 17 00:00:00 2001 From: Joehu Date: Sun, 22 Dec 2019 19:47:47 -0800 Subject: [PATCH 3/3] Rename property to IsSwitchable --- osu.Game/Overlays/ChatOverlay.cs | 2 +- osu.Game/Screens/Select/BeatmapDetailAreaTabControl.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/osu.Game/Overlays/ChatOverlay.cs b/osu.Game/Overlays/ChatOverlay.cs index 08043a097b..e80c51d82a 100644 --- a/osu.Game/Overlays/ChatOverlay.cs +++ b/osu.Game/Overlays/ChatOverlay.cs @@ -171,7 +171,7 @@ namespace osu.Game.Overlays d.Origin = Anchor.BottomLeft; d.RelativeSizeAxes = Axes.Both; d.OnRequestLeave = channelManager.LeaveChannel; - d.Tabbable = true; + d.IsSwitchable = true; }), } }, diff --git a/osu.Game/Screens/Select/BeatmapDetailAreaTabControl.cs b/osu.Game/Screens/Select/BeatmapDetailAreaTabControl.cs index a6933b478e..19ecdb6dbf 100644 --- a/osu.Game/Screens/Select/BeatmapDetailAreaTabControl.cs +++ b/osu.Game/Screens/Select/BeatmapDetailAreaTabControl.cs @@ -48,7 +48,7 @@ namespace osu.Game.Screens.Select Anchor = Anchor.BottomLeft, Origin = Anchor.BottomLeft, RelativeSizeAxes = Axes.Both, - Tabbable = true, + IsSwitchable = true, }, }, modsCheckbox = new OsuTabControlCheckbox