From 1f2fba6e235a913d8d5308001393703d091cb581 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= Date: Wed, 7 May 2025 09:15:15 +0200 Subject: [PATCH] Ignore "image proxying" test scene Because it just failed thrice (https://github.com/ppy/osu/runs/41775675413#r0) and to me it seems like a profoundly bad idea. I considered having it retry like the framework precedent of this (https://github.com/ppy/osu-framework/blob/dd2b701ed84c687ff71f5c50338d3b325159ee45/osu.Framework.Tests/IO/TestWebRequest.cs#L69) before I noticed that it was also hitting hardcoded production endpoints at which point I decided it was just too weird to live. --- osu.Game.Tests/Visual/Online/TestSceneImageProxying.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/osu.Game.Tests/Visual/Online/TestSceneImageProxying.cs b/osu.Game.Tests/Visual/Online/TestSceneImageProxying.cs index 3d7ee137ba..60b10b9899 100644 --- a/osu.Game.Tests/Visual/Online/TestSceneImageProxying.cs +++ b/osu.Game.Tests/Visual/Online/TestSceneImageProxying.cs @@ -12,6 +12,7 @@ using osu.Game.Overlays.Comments; namespace osu.Game.Tests.Visual.Online { + [Ignore("This test hits online resources (and online retrieval can fail at any time), and also performs network calls to the production instance of the website. Un-ignore this test when it's actually actively needed.")] public partial class TestSceneImageProxying : OsuTestScene { [Test]