mirror of
https://github.com/ppy/osu.git
synced 2024-09-22 03:27:24 +08:00
Merge pull request #21751 from bdach/fix-mania-hold-note-crash
Fix crashes on quick-retrying when holding note in mania
This commit is contained in:
commit
36b6163475
@ -134,6 +134,9 @@ namespace osu.Game.Rulesets.Mania.UI
|
|||||||
|
|
||||||
protected override void Dispose(bool isDisposing)
|
protected override void Dispose(bool isDisposing)
|
||||||
{
|
{
|
||||||
|
// must happen before children are disposed in base call to prevent illegal accesses to the hit explosion pool.
|
||||||
|
NewResult -= OnNewResult;
|
||||||
|
|
||||||
base.Dispose(isDisposing);
|
base.Dispose(isDisposing);
|
||||||
|
|
||||||
if (skin != null)
|
if (skin != null)
|
||||||
|
@ -156,6 +156,9 @@ namespace osu.Game.Rulesets.Mania.UI
|
|||||||
|
|
||||||
protected override void Dispose(bool isDisposing)
|
protected override void Dispose(bool isDisposing)
|
||||||
{
|
{
|
||||||
|
// must happen before children are disposed in base call to prevent illegal accesses to the judgement pool.
|
||||||
|
NewResult -= OnNewResult;
|
||||||
|
|
||||||
base.Dispose(isDisposing);
|
base.Dispose(isDisposing);
|
||||||
|
|
||||||
if (currentSkin != null)
|
if (currentSkin != null)
|
||||||
|
Loading…
Reference in New Issue
Block a user