h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-28 20:47:22 +08:00
Code Issues Releases Wiki Activity

Use bindable lease instead of reimplementing the same thing locally

Browse Source
This commit is contained in:
Dean Herbert 2023-06-21 16:09:54 +09:00
parent d7b486e2ac
commit 366dd96875
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
osu.Game/Overlays/SkinEditor/SkinEditorOverlay.cs
View File

@ -203,7 +203,7 @@ namespace osu.Game.Overlays.SkinEditor
} }
private readonly Bindable<bool> beatmapSkins = new Bindable<bool>(); private readonly Bindable<bool> beatmapSkins = new Bindable<bool>();
private bool beatmapSkinsOriginalState; private LeasedBindable<bool>? leasedBeatmapSkins;
private void globallyDisableBeatmapSkinSetting() private void globallyDisableBeatmapSkinSetting()
{ {
@ -212,19 +212,14 @@ namespace osu.Game.Overlays.SkinEditor
// The skin editor doesn't work well if beatmap skins are being applied to the player screen. // The skin editor doesn't work well if beatmap skins are being applied to the player screen.
// To keep things simple, disable the setting game-wide while using the skin editor. // To keep things simple, disable the setting game-wide while using the skin editor.
beatmapSkinsOriginalState = beatmapSkins.Value; leasedBeatmapSkins = beatmapSkins.BeginLease(true);
leasedBeatmapSkins.Value = false;
beatmapSkins.Value = false;
beatmapSkins.Disabled = true;
} }
private void globallyReenableBeatmapSkinSetting() private void globallyReenableBeatmapSkinSetting()
{ {
if (!beatmapSkins.Disabled) leasedBeatmapSkins?.Return();
return; leasedBeatmapSkins = null;
beatmapSkins.Disabled = false;
beatmapSkins.Value = beatmapSkinsOriginalState;
} }
} }
} }