h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-14 15:57:24 +08:00
Code Issues Releases Wiki Activity

Avoid clearing chat overlay textbox when pressing "back" key binding

Browse Source 
Generally this is expected behaviour for usages of focused text boxes
(ie. to clear search content), but not so much here.

Addresses https://github.com/ppy/osu/discussions/19403#discussioncomment-3230395.
This commit is contained in:
Dean Herbert 2022-08-02 13:56:02 +09:00
parent fc0914bf77
commit 34ffc51c51
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Graphics/UserInterface/FocusedTextBox.cs
View File

@ -21,6 +21,11 @@ namespace osu.Game.Graphics.UserInterface
private bool allowImmediateFocus => host?.OnScreenKeyboardOverlapsGameWindow != true; private bool allowImmediateFocus => host?.OnScreenKeyboardOverlapsGameWindow != true;
/// <summary>
/// Whether the content of the text box should be cleared on the first "back" key press.
/// </summary>
protected virtual bool ClearTextOnBackKey => true;
public void TakeFocus() public void TakeFocus()
{ {
if (!allowImmediateFocus) if (!allowImmediateFocus)
@ -78,7 +83,7 @@ namespace osu.Game.Graphics.UserInterface
if (!HasFocus) return false; if (!HasFocus) return false;
if (e.Action == GlobalAction.Back) if (ClearTextOnBackKey && e.Action == GlobalAction.Back)
{ {
if (Text.Length > 0) if (Text.Length > 0)
{ {

2
osu.Game/Overlays/Chat/ChatTextBox.cs
View File

@ -13,6 +13,8 @@ namespace osu.Game.Overlays.Chat
public override bool HandleLeftRightArrows => !ShowSearch.Value; public override bool HandleLeftRightArrows => !ShowSearch.Value;
protected override bool ClearTextOnBackKey => false;
protected override void LoadComplete() protected override void LoadComplete()
{ {
base.LoadComplete(); base.LoadComplete();