h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-02 19:00:10 +08:00
Code Issues Releases Wiki Activity

Remove unnecessary IsActive variable

Browse Source
This commit is contained in:
Alden Wu
2022-10-03 16:07:39 -07:00
Unverified
parent c1da3bc9cf
commit 343bdaa98e
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game.Rulesets.Osu/Skinning/Smoke.cs
+5 -8
View File
@@ -40,7 +40,6 @@ namespace osu.Game.Rulesets.Osu.Skinning
protected double SmokeEndTime { get; private set; } = double.MaxValue;
protected virtual float PointInterval => Radius * 7f / 8;
protected bool IsActive { get; private set; }
protected readonly List<SmokePoint> SmokePoints = new List<SmokePoint>();
@@ -73,7 +72,6 @@ namespace osu.Game.Rulesets.Osu.Skinning
{
smokeContainer.SmokeMoved += onSmokeMoved;
smokeContainer.SmokeEnded += onSmokeEnded;
IsActive = true;
onSmokeMoved(smokeContainer.LastMousePosition, Time.Current);
}
@@ -87,9 +85,6 @@ namespace osu.Game.Rulesets.Osu.Skinning
private void onSmokeMoved(Vector2 position, double time)
{
if (!IsActive)
return;
lastPosition ??= position;
float delta = (position - (Vector2)lastPosition).LengthFast;
@@ -137,10 +132,12 @@ namespace osu.Game.Rulesets.Osu.Skinning
private void onSmokeEnded(double time)
{
if (!IsActive)
return;
if (smokeContainer != null)
{
smokeContainer.SmokeMoved -= onSmokeMoved;
smokeContainer.SmokeEnded -= onSmokeEnded;
}
IsActive = false;
SmokeEndTime = time;
}