mirror of
https://github.com/ppy/osu.git
synced 2024-12-16 18:23:01 +08:00
Merge branch 'master' into present-replay-from-ss
This commit is contained in:
commit
3291d7b6c9
@ -54,6 +54,6 @@
|
|||||||
</ItemGroup>
|
</ItemGroup>
|
||||||
<ItemGroup>
|
<ItemGroup>
|
||||||
<PackageReference Include="ppy.osu.Game.Resources" Version="2019.1230.0" />
|
<PackageReference Include="ppy.osu.Game.Resources" Version="2019.1230.0" />
|
||||||
<PackageReference Include="ppy.osu.Framework.Android" Version="2020.130.0" />
|
<PackageReference Include="ppy.osu.Framework.Android" Version="2020.131.0" />
|
||||||
</ItemGroup>
|
</ItemGroup>
|
||||||
</Project>
|
</Project>
|
||||||
|
@ -20,7 +20,9 @@ namespace osu.Game.Rulesets.Catch.UI
|
|||||||
|
|
||||||
internal readonly CatcherArea CatcherArea;
|
internal readonly CatcherArea CatcherArea;
|
||||||
|
|
||||||
public override bool ReceivePositionalInputAt(Vector2 screenSpacePos) => base.ReceivePositionalInputAt(screenSpacePos) || CatcherArea.ReceivePositionalInputAt(screenSpacePos);
|
public override bool ReceivePositionalInputAt(Vector2 screenSpacePos) =>
|
||||||
|
// only check the X position; handle all vertical space.
|
||||||
|
base.ReceivePositionalInputAt(new Vector2(screenSpacePos.X, ScreenSpaceDrawQuad.Centre.Y));
|
||||||
|
|
||||||
public CatchPlayfield(BeatmapDifficulty difficulty, Func<CatchHitObject, DrawableHitObject<CatchHitObject>> createDrawableRepresentation)
|
public CatchPlayfield(BeatmapDifficulty difficulty, Func<CatchHitObject, DrawableHitObject<CatchHitObject>> createDrawableRepresentation)
|
||||||
{
|
{
|
||||||
|
@ -7,12 +7,10 @@ using System.Linq;
|
|||||||
using NUnit.Framework;
|
using NUnit.Framework;
|
||||||
using osu.Framework.Allocation;
|
using osu.Framework.Allocation;
|
||||||
using osu.Framework.Audio;
|
using osu.Framework.Audio;
|
||||||
using osu.Framework.Graphics;
|
|
||||||
using osu.Framework.IO.Stores;
|
using osu.Framework.IO.Stores;
|
||||||
using osu.Framework.Testing;
|
using osu.Framework.Testing;
|
||||||
using osu.Game.Beatmaps;
|
using osu.Game.Beatmaps;
|
||||||
using osu.Game.Rulesets.Osu.Objects;
|
using osu.Game.Rulesets.Osu.Objects;
|
||||||
using osu.Game.Screens;
|
|
||||||
using osu.Game.Screens.Play;
|
using osu.Game.Screens.Play;
|
||||||
using osu.Game.Skinning;
|
using osu.Game.Skinning;
|
||||||
using osu.Game.Tests.Visual;
|
using osu.Game.Tests.Visual;
|
||||||
@ -21,7 +19,7 @@ using osuTK.Graphics;
|
|||||||
|
|
||||||
namespace osu.Game.Rulesets.Osu.Tests
|
namespace osu.Game.Rulesets.Osu.Tests
|
||||||
{
|
{
|
||||||
public class TestSceneLegacyBeatmapSkin : OsuTestScene
|
public class TestSceneLegacyBeatmapSkin : ScreenTestScene
|
||||||
{
|
{
|
||||||
[Resolved]
|
[Resolved]
|
||||||
private AudioManager audio { get; set; }
|
private AudioManager audio { get; set; }
|
||||||
@ -65,7 +63,8 @@ namespace osu.Game.Rulesets.Osu.Tests
|
|||||||
ExposedPlayer player;
|
ExposedPlayer player;
|
||||||
|
|
||||||
Beatmap.Value = new CustomSkinWorkingBeatmap(audio, beatmapHasColours);
|
Beatmap.Value = new CustomSkinWorkingBeatmap(audio, beatmapHasColours);
|
||||||
Child = new OsuScreenStack(player = new ExposedPlayer(userHasCustomColours)) { RelativeSizeAxes = Axes.Both };
|
|
||||||
|
LoadScreen(player = new ExposedPlayer(userHasCustomColours));
|
||||||
|
|
||||||
return player;
|
return player;
|
||||||
}
|
}
|
||||||
|
@ -4,7 +4,7 @@
|
|||||||
<PackageReference Include="Appveyor.TestLogger" Version="2.0.0" />
|
<PackageReference Include="Appveyor.TestLogger" Version="2.0.0" />
|
||||||
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
|
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
|
||||||
<PackageReference Include="NUnit" Version="3.12.0" />
|
<PackageReference Include="NUnit" Version="3.12.0" />
|
||||||
<PackageReference Include="NUnit3TestAdapter" Version="3.16.0" />
|
<PackageReference Include="NUnit3TestAdapter" Version="3.15.1" />
|
||||||
<PackageReference Update="Microsoft.EntityFrameworkCore.Sqlite" Version="2.1.4" />
|
<PackageReference Update="Microsoft.EntityFrameworkCore.Sqlite" Version="2.1.4" />
|
||||||
</ItemGroup>
|
</ItemGroup>
|
||||||
<PropertyGroup Label="Project">
|
<PropertyGroup Label="Project">
|
||||||
|
@ -2,49 +2,66 @@
|
|||||||
// See the LICENCE file in the repository root for full licence text.
|
// See the LICENCE file in the repository root for full licence text.
|
||||||
|
|
||||||
using System.Linq;
|
using System.Linq;
|
||||||
|
using NUnit.Framework;
|
||||||
using osu.Framework.Allocation;
|
using osu.Framework.Allocation;
|
||||||
using osu.Framework.Screens;
|
using osu.Framework.Screens;
|
||||||
using osu.Game.Configuration;
|
using osu.Game.Configuration;
|
||||||
using osu.Game.Rulesets;
|
using osu.Game.Rulesets;
|
||||||
|
using osu.Game.Rulesets.Catch;
|
||||||
|
using osu.Game.Rulesets.Mania;
|
||||||
using osu.Game.Rulesets.Mods;
|
using osu.Game.Rulesets.Mods;
|
||||||
|
using osu.Game.Rulesets.Osu;
|
||||||
|
using osu.Game.Rulesets.Taiko;
|
||||||
using osu.Game.Screens.Play;
|
using osu.Game.Screens.Play;
|
||||||
|
|
||||||
namespace osu.Game.Tests.Visual
|
namespace osu.Game.Tests.Visual.Gameplay
|
||||||
{
|
{
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// A base class which runs <see cref="Player"/> test for all available rulesets.
|
/// A base class which runs <see cref="Player"/> test for all available rulesets.
|
||||||
/// Steps to be run for each ruleset should be added via <see cref="AddCheckSteps"/>.
|
/// Steps to be run for each ruleset should be added via <see cref="AddCheckSteps"/>.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public abstract class AllPlayersTestScene : RateAdjustedBeatmapTestScene
|
public abstract class TestSceneAllRulesetPlayers : RateAdjustedBeatmapTestScene
|
||||||
{
|
{
|
||||||
protected Player Player;
|
protected Player Player;
|
||||||
|
|
||||||
[BackgroundDependencyLoader]
|
[BackgroundDependencyLoader]
|
||||||
private void load(RulesetStore rulesets)
|
private void load(RulesetStore rulesets)
|
||||||
{
|
{
|
||||||
foreach (var r in rulesets.AvailableRulesets)
|
|
||||||
{
|
|
||||||
Player p = null;
|
|
||||||
AddStep(r.Name, () => p = loadPlayerFor(r));
|
|
||||||
AddUntilStep("player loaded", () =>
|
|
||||||
{
|
|
||||||
if (p?.IsLoaded == true)
|
|
||||||
{
|
|
||||||
p = null;
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
|
|
||||||
return false;
|
|
||||||
});
|
|
||||||
|
|
||||||
AddCheckSteps();
|
|
||||||
}
|
|
||||||
|
|
||||||
OsuConfigManager manager;
|
OsuConfigManager manager;
|
||||||
Dependencies.Cache(manager = new OsuConfigManager(LocalStorage));
|
Dependencies.Cache(manager = new OsuConfigManager(LocalStorage));
|
||||||
manager.GetBindable<double>(OsuSetting.DimLevel).Value = 1.0;
|
manager.GetBindable<double>(OsuSetting.DimLevel).Value = 1.0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void TestOsu() => runForRuleset(new OsuRuleset().RulesetInfo);
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void TestTaiko() => runForRuleset(new TaikoRuleset().RulesetInfo);
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void TestCatch() => runForRuleset(new CatchRuleset().RulesetInfo);
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void TestMania() => runForRuleset(new ManiaRuleset().RulesetInfo);
|
||||||
|
|
||||||
|
private void runForRuleset(RulesetInfo ruleset)
|
||||||
|
{
|
||||||
|
Player p = null;
|
||||||
|
AddStep($"load {ruleset.Name} player", () => p = loadPlayerFor(ruleset));
|
||||||
|
AddUntilStep("player loaded", () =>
|
||||||
|
{
|
||||||
|
if (p?.IsLoaded == true)
|
||||||
|
{
|
||||||
|
p = null;
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
return false;
|
||||||
|
});
|
||||||
|
|
||||||
|
AddCheckSteps();
|
||||||
|
}
|
||||||
|
|
||||||
protected abstract void AddCheckSteps();
|
protected abstract void AddCheckSteps();
|
||||||
|
|
||||||
private Player loadPlayerFor(RulesetInfo rulesetInfo)
|
private Player loadPlayerFor(RulesetInfo rulesetInfo)
|
@ -12,7 +12,7 @@ using osu.Game.Storyboards;
|
|||||||
namespace osu.Game.Tests.Visual.Gameplay
|
namespace osu.Game.Tests.Visual.Gameplay
|
||||||
{
|
{
|
||||||
[Description("Player instantiated with an autoplay mod.")]
|
[Description("Player instantiated with an autoplay mod.")]
|
||||||
public class TestSceneAutoplay : AllPlayersTestScene
|
public class TestSceneAutoplay : TestSceneAllRulesetPlayers
|
||||||
{
|
{
|
||||||
private ClockBackedTestWorkingBeatmap.TrackVirtualManual track;
|
private ClockBackedTestWorkingBeatmap.TrackVirtualManual track;
|
||||||
|
|
||||||
|
@ -10,7 +10,7 @@ using osu.Game.Screens.Play;
|
|||||||
|
|
||||||
namespace osu.Game.Tests.Visual.Gameplay
|
namespace osu.Game.Tests.Visual.Gameplay
|
||||||
{
|
{
|
||||||
public class TestSceneFailAnimation : AllPlayersTestScene
|
public class TestSceneFailAnimation : TestSceneAllRulesetPlayers
|
||||||
{
|
{
|
||||||
protected override Player CreatePlayer(Ruleset ruleset)
|
protected override Player CreatePlayer(Ruleset ruleset)
|
||||||
{
|
{
|
||||||
@ -20,7 +20,7 @@ namespace osu.Game.Tests.Visual.Gameplay
|
|||||||
|
|
||||||
public override IReadOnlyList<Type> RequiredTypes => new[]
|
public override IReadOnlyList<Type> RequiredTypes => new[]
|
||||||
{
|
{
|
||||||
typeof(AllPlayersTestScene),
|
typeof(TestSceneAllRulesetPlayers),
|
||||||
typeof(TestPlayer),
|
typeof(TestPlayer),
|
||||||
typeof(Player),
|
typeof(Player),
|
||||||
};
|
};
|
||||||
|
@ -10,7 +10,7 @@ using osu.Game.Screens.Play;
|
|||||||
|
|
||||||
namespace osu.Game.Tests.Visual.Gameplay
|
namespace osu.Game.Tests.Visual.Gameplay
|
||||||
{
|
{
|
||||||
public class TestSceneFailJudgement : AllPlayersTestScene
|
public class TestSceneFailJudgement : TestSceneAllRulesetPlayers
|
||||||
{
|
{
|
||||||
protected override Player CreatePlayer(Ruleset ruleset)
|
protected override Player CreatePlayer(Ruleset ruleset)
|
||||||
{
|
{
|
||||||
|
@ -36,6 +36,7 @@ namespace osu.Game.Tests.Visual.Gameplay
|
|||||||
public override void SetUpSteps()
|
public override void SetUpSteps()
|
||||||
{
|
{
|
||||||
base.SetUpSteps();
|
base.SetUpSteps();
|
||||||
|
|
||||||
AddStep("resume player", () => Player.GameplayClockContainer.Start());
|
AddStep("resume player", () => Player.GameplayClockContainer.Start());
|
||||||
confirmClockRunning(true);
|
confirmClockRunning(true);
|
||||||
}
|
}
|
||||||
|
@ -10,7 +10,7 @@ using osu.Game.Storyboards;
|
|||||||
|
|
||||||
namespace osu.Game.Tests.Visual.Gameplay
|
namespace osu.Game.Tests.Visual.Gameplay
|
||||||
{
|
{
|
||||||
public class TestScenePlayerReferenceLeaking : AllPlayersTestScene
|
public class TestScenePlayerReferenceLeaking : TestSceneAllRulesetPlayers
|
||||||
{
|
{
|
||||||
private readonly WeakList<WorkingBeatmap> workingWeakReferences = new WeakList<WorkingBeatmap>();
|
private readonly WeakList<WorkingBeatmap> workingWeakReferences = new WeakList<WorkingBeatmap>();
|
||||||
|
|
||||||
|
@ -13,7 +13,7 @@ using osu.Game.Screens.Play;
|
|||||||
namespace osu.Game.Tests.Visual.Gameplay
|
namespace osu.Game.Tests.Visual.Gameplay
|
||||||
{
|
{
|
||||||
[Description("Player instantiated with a replay.")]
|
[Description("Player instantiated with a replay.")]
|
||||||
public class TestSceneReplay : AllPlayersTestScene
|
public class TestSceneReplay : TestSceneAllRulesetPlayers
|
||||||
{
|
{
|
||||||
protected override Player CreatePlayer(Ruleset ruleset)
|
protected override Player CreatePlayer(Ruleset ruleset)
|
||||||
{
|
{
|
||||||
|
@ -30,7 +30,6 @@ namespace osu.Game.Tests.Visual.Navigation
|
|||||||
}
|
}
|
||||||
|
|
||||||
[Test]
|
[Test]
|
||||||
[Ignore("will be fixed soon")]
|
|
||||||
public void TestFromMainMenuDifferentRuleset()
|
public void TestFromMainMenuDifferentRuleset()
|
||||||
{
|
{
|
||||||
var firstImport = importBeatmap(1);
|
var firstImport = importBeatmap(1);
|
||||||
|
@ -3,12 +3,15 @@
|
|||||||
|
|
||||||
using System;
|
using System;
|
||||||
using System.Collections.Generic;
|
using System.Collections.Generic;
|
||||||
|
using System.Linq;
|
||||||
using NUnit.Framework;
|
using NUnit.Framework;
|
||||||
using osu.Framework.Allocation;
|
using osu.Framework.Allocation;
|
||||||
using osu.Framework.Bindables;
|
using osu.Framework.Bindables;
|
||||||
using osu.Framework.Graphics;
|
using osu.Framework.Graphics;
|
||||||
using osu.Framework.Graphics.Containers;
|
using osu.Framework.Graphics.Containers;
|
||||||
using osu.Framework.Graphics.UserInterface;
|
using osu.Framework.Graphics.UserInterface;
|
||||||
|
using osu.Framework.Testing;
|
||||||
|
using osu.Game.Graphics.UserInterface;
|
||||||
using osu.Game.Online.Chat;
|
using osu.Game.Online.Chat;
|
||||||
using osu.Game.Overlays;
|
using osu.Game.Overlays;
|
||||||
using osu.Game.Overlays.Chat;
|
using osu.Game.Overlays.Chat;
|
||||||
@ -35,8 +38,9 @@ namespace osu.Game.Tests.Visual.Online
|
|||||||
private TestChatOverlay chatOverlay;
|
private TestChatOverlay chatOverlay;
|
||||||
private ChannelManager channelManager;
|
private ChannelManager channelManager;
|
||||||
|
|
||||||
private readonly Channel channel1 = new Channel(new User()) { Name = "test really long username" };
|
private readonly Channel channel1 = new Channel(new User()) { Name = "test really long username", Topic = "Topic for channel 1" };
|
||||||
private readonly Channel channel2 = new Channel(new User()) { Name = "test2" };
|
private readonly Channel channel2 = new Channel(new User()) { Name = "test2", Topic = "Topic for channel 2" };
|
||||||
|
private readonly Channel channel3 = new Channel(new User()) { Name = "channel with no topic" };
|
||||||
|
|
||||||
[SetUp]
|
[SetUp]
|
||||||
public void Setup()
|
public void Setup()
|
||||||
@ -45,7 +49,7 @@ namespace osu.Game.Tests.Visual.Online
|
|||||||
{
|
{
|
||||||
ChannelManagerContainer container;
|
ChannelManagerContainer container;
|
||||||
|
|
||||||
Child = container = new ChannelManagerContainer(new List<Channel> { channel1, channel2 })
|
Child = container = new ChannelManagerContainer(new List<Channel> { channel1, channel2, channel3 })
|
||||||
{
|
{
|
||||||
RelativeSizeAxes = Axes.Both,
|
RelativeSizeAxes = Axes.Both,
|
||||||
};
|
};
|
||||||
@ -96,6 +100,17 @@ namespace osu.Game.Tests.Visual.Online
|
|||||||
AddAssert("Selector is visible", () => chatOverlay.SelectionOverlayState == Visibility.Visible);
|
AddAssert("Selector is visible", () => chatOverlay.SelectionOverlayState == Visibility.Visible);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void TestSearchInSelector()
|
||||||
|
{
|
||||||
|
AddStep("search for 'test2'", () => chatOverlay.ChildrenOfType<SearchTextBox>().First().Text = "test2");
|
||||||
|
AddUntilStep("only channel 2 visible", () =>
|
||||||
|
{
|
||||||
|
var listItems = chatOverlay.ChildrenOfType<ChannelListItem>().Where(c => c.IsPresent);
|
||||||
|
return listItems.Count() == 1 && listItems.Single().Channel == channel2;
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
private void clickDrawable(Drawable d)
|
private void clickDrawable(Drawable d)
|
||||||
{
|
{
|
||||||
InputManager.MoveMouseTo(d);
|
InputManager.MoveMouseTo(d);
|
||||||
|
@ -72,19 +72,24 @@ namespace osu.Game.Tests.Visual.SongSelect
|
|||||||
// required to get bindables attached
|
// required to get bindables attached
|
||||||
Add(music);
|
Add(music);
|
||||||
|
|
||||||
Beatmap.SetDefault();
|
|
||||||
|
|
||||||
Dependencies.Cache(config = new OsuConfigManager(LocalStorage));
|
Dependencies.Cache(config = new OsuConfigManager(LocalStorage));
|
||||||
}
|
}
|
||||||
|
|
||||||
private OsuConfigManager config;
|
private OsuConfigManager config;
|
||||||
|
|
||||||
[SetUp]
|
[SetUpSteps]
|
||||||
public virtual void SetUp() => Schedule(() =>
|
public override void SetUpSteps()
|
||||||
{
|
{
|
||||||
Ruleset.Value = new OsuRuleset().RulesetInfo;
|
base.SetUpSteps();
|
||||||
manager?.Delete(manager.GetAllUsableBeatmapSets());
|
|
||||||
});
|
AddStep("delete all beatmaps", () =>
|
||||||
|
{
|
||||||
|
Ruleset.Value = new OsuRuleset().RulesetInfo;
|
||||||
|
manager?.Delete(manager.GetAllUsableBeatmapSets());
|
||||||
|
|
||||||
|
Beatmap.SetDefault();
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
[Test]
|
[Test]
|
||||||
public void TestSingleFilterOnEnter()
|
public void TestSingleFilterOnEnter()
|
||||||
@ -120,9 +125,6 @@ namespace osu.Game.Tests.Visual.SongSelect
|
|||||||
|
|
||||||
AddUntilStep("wait for not current", () => !songSelect.IsCurrentScreen());
|
AddUntilStep("wait for not current", () => !songSelect.IsCurrentScreen());
|
||||||
AddAssert("ensure selection changed", () => selected != Beatmap.Value);
|
AddAssert("ensure selection changed", () => selected != Beatmap.Value);
|
||||||
|
|
||||||
AddUntilStep("wait for return to song select", () => songSelect.IsCurrentScreen());
|
|
||||||
AddUntilStep("bindable lease returned", () => !Beatmap.Disabled);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
[Test]
|
[Test]
|
||||||
@ -148,9 +150,6 @@ namespace osu.Game.Tests.Visual.SongSelect
|
|||||||
|
|
||||||
AddUntilStep("wait for not current", () => !songSelect.IsCurrentScreen());
|
AddUntilStep("wait for not current", () => !songSelect.IsCurrentScreen());
|
||||||
AddAssert("ensure selection didn't change", () => selected == Beatmap.Value);
|
AddAssert("ensure selection didn't change", () => selected == Beatmap.Value);
|
||||||
|
|
||||||
AddUntilStep("wait for return to song select", () => songSelect.IsCurrentScreen());
|
|
||||||
AddUntilStep("bindable lease returned", () => !Beatmap.Disabled);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
[Test]
|
[Test]
|
||||||
@ -180,9 +179,6 @@ namespace osu.Game.Tests.Visual.SongSelect
|
|||||||
|
|
||||||
AddUntilStep("wait for not current", () => !songSelect.IsCurrentScreen());
|
AddUntilStep("wait for not current", () => !songSelect.IsCurrentScreen());
|
||||||
AddAssert("ensure selection changed", () => selected != Beatmap.Value);
|
AddAssert("ensure selection changed", () => selected != Beatmap.Value);
|
||||||
|
|
||||||
AddUntilStep("wait for return to song select", () => songSelect.IsCurrentScreen());
|
|
||||||
AddUntilStep("bindable lease returned", () => !Beatmap.Disabled);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
[Test]
|
[Test]
|
||||||
@ -213,9 +209,6 @@ namespace osu.Game.Tests.Visual.SongSelect
|
|||||||
|
|
||||||
AddUntilStep("wait for not current", () => !songSelect.IsCurrentScreen());
|
AddUntilStep("wait for not current", () => !songSelect.IsCurrentScreen());
|
||||||
AddAssert("ensure selection didn't change", () => selected == Beatmap.Value);
|
AddAssert("ensure selection didn't change", () => selected == Beatmap.Value);
|
||||||
|
|
||||||
AddUntilStep("wait for return to song select", () => songSelect.IsCurrentScreen());
|
|
||||||
AddUntilStep("bindable lease returned", () => !Beatmap.Disabled);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
[Test]
|
[Test]
|
||||||
|
@ -25,7 +25,7 @@ namespace osu.Game.Overlays.Chat.Selection
|
|||||||
private const float text_size = 15;
|
private const float text_size = 15;
|
||||||
private const float transition_duration = 100;
|
private const float transition_duration = 100;
|
||||||
|
|
||||||
private readonly Channel channel;
|
public readonly Channel Channel;
|
||||||
|
|
||||||
private readonly Bindable<bool> joinedBind = new Bindable<bool>();
|
private readonly Bindable<bool> joinedBind = new Bindable<bool>();
|
||||||
private readonly OsuSpriteText name;
|
private readonly OsuSpriteText name;
|
||||||
@ -36,7 +36,7 @@ namespace osu.Game.Overlays.Chat.Selection
|
|||||||
private Color4 topicColour;
|
private Color4 topicColour;
|
||||||
private Color4 hoverColour;
|
private Color4 hoverColour;
|
||||||
|
|
||||||
public IEnumerable<string> FilterTerms => new[] { channel.Name, channel.Topic };
|
public IEnumerable<string> FilterTerms => new[] { Channel.Name, Channel.Topic ?? string.Empty };
|
||||||
|
|
||||||
public bool MatchingFilter
|
public bool MatchingFilter
|
||||||
{
|
{
|
||||||
@ -50,7 +50,7 @@ namespace osu.Game.Overlays.Chat.Selection
|
|||||||
|
|
||||||
public ChannelListItem(Channel channel)
|
public ChannelListItem(Channel channel)
|
||||||
{
|
{
|
||||||
this.channel = channel;
|
Channel = channel;
|
||||||
|
|
||||||
RelativeSizeAxes = Axes.X;
|
RelativeSizeAxes = Axes.X;
|
||||||
AutoSizeAxes = Axes.Y;
|
AutoSizeAxes = Axes.Y;
|
||||||
@ -148,7 +148,7 @@ namespace osu.Game.Overlays.Chat.Selection
|
|||||||
hoverColour = colours.Yellow;
|
hoverColour = colours.Yellow;
|
||||||
|
|
||||||
joinedBind.ValueChanged += joined => updateColour(joined.NewValue);
|
joinedBind.ValueChanged += joined => updateColour(joined.NewValue);
|
||||||
joinedBind.BindTo(channel.Joined);
|
joinedBind.BindTo(Channel.Joined);
|
||||||
|
|
||||||
joinedBind.TriggerChange();
|
joinedBind.TriggerChange();
|
||||||
FinishTransforms(true);
|
FinishTransforms(true);
|
||||||
@ -156,7 +156,7 @@ namespace osu.Game.Overlays.Chat.Selection
|
|||||||
|
|
||||||
protected override bool OnHover(HoverEvent e)
|
protected override bool OnHover(HoverEvent e)
|
||||||
{
|
{
|
||||||
if (!channel.Joined.Value)
|
if (!Channel.Joined.Value)
|
||||||
name.FadeColour(hoverColour, 50, Easing.OutQuint);
|
name.FadeColour(hoverColour, 50, Easing.OutQuint);
|
||||||
|
|
||||||
return base.OnHover(e);
|
return base.OnHover(e);
|
||||||
@ -164,7 +164,7 @@ namespace osu.Game.Overlays.Chat.Selection
|
|||||||
|
|
||||||
protected override void OnHoverLost(HoverLostEvent e)
|
protected override void OnHoverLost(HoverLostEvent e)
|
||||||
{
|
{
|
||||||
if (!channel.Joined.Value)
|
if (!Channel.Joined.Value)
|
||||||
name.FadeColour(Color4.White, transition_duration);
|
name.FadeColour(Color4.White, transition_duration);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -220,9 +220,11 @@ namespace osu.Game.Scoring.Legacy
|
|||||||
float lastTime = 0;
|
float lastTime = 0;
|
||||||
ReplayFrame currentFrame = null;
|
ReplayFrame currentFrame = null;
|
||||||
|
|
||||||
foreach (var l in reader.ReadToEnd().Split(','))
|
var frames = reader.ReadToEnd().Split(',');
|
||||||
|
|
||||||
|
for (var i = 0; i < frames.Length; i++)
|
||||||
{
|
{
|
||||||
var split = l.Split('|');
|
var split = frames[i].Split('|');
|
||||||
|
|
||||||
if (split.Length < 4)
|
if (split.Length < 4)
|
||||||
continue;
|
continue;
|
||||||
@ -234,8 +236,14 @@ namespace osu.Game.Scoring.Legacy
|
|||||||
}
|
}
|
||||||
|
|
||||||
var diff = Parsing.ParseFloat(split[0]);
|
var diff = Parsing.ParseFloat(split[0]);
|
||||||
|
|
||||||
lastTime += diff;
|
lastTime += diff;
|
||||||
|
|
||||||
|
if (i == 0 && diff == 0)
|
||||||
|
// osu-stable adds a zero-time frame before potentially valid negative user frames.
|
||||||
|
// we need to ignore this.
|
||||||
|
continue;
|
||||||
|
|
||||||
// Todo: At some point we probably want to rewind and play back the negative-time frames
|
// Todo: At some point we probably want to rewind and play back the negative-time frames
|
||||||
// but for now we'll achieve equal playback to stable by skipping negative frames
|
// but for now we'll achieve equal playback to stable by skipping negative frames
|
||||||
if (diff < 0)
|
if (diff < 0)
|
||||||
|
@ -289,7 +289,7 @@ namespace osu.Game.Screens.Select
|
|||||||
// if not the current screen, we want to get carousel in a good presentation state before displaying (resume or enter).
|
// if not the current screen, we want to get carousel in a good presentation state before displaying (resume or enter).
|
||||||
bool shouldDebounce = this.IsCurrentScreen();
|
bool shouldDebounce = this.IsCurrentScreen();
|
||||||
|
|
||||||
Schedule(() => Carousel.Filter(criteria, shouldDebounce));
|
Carousel.Filter(criteria, shouldDebounce);
|
||||||
}
|
}
|
||||||
|
|
||||||
private DependencyContainer dependencies;
|
private DependencyContainer dependencies;
|
||||||
@ -328,8 +328,10 @@ namespace osu.Game.Screens.Select
|
|||||||
if (!Carousel.BeatmapSetsLoaded)
|
if (!Carousel.BeatmapSetsLoaded)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
// if we have a pending filter operation, we want to run it now.
|
transferRulesetValue();
|
||||||
// it could change selection (ie. if the ruleset has been changed).
|
|
||||||
|
// while transferRulesetValue will flush, it only does so if the ruleset changes.
|
||||||
|
// the user could have changed a filter, and we want to ensure we are 100% up-to-date and consistent here.
|
||||||
Carousel.FlushPendingFilterOperations();
|
Carousel.FlushPendingFilterOperations();
|
||||||
|
|
||||||
// avoid attempting to continue before a selection has been obtained.
|
// avoid attempting to continue before a selection has been obtained.
|
||||||
@ -346,8 +348,8 @@ namespace osu.Game.Screens.Select
|
|||||||
selectionChangedDebounce = null;
|
selectionChangedDebounce = null;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (performStartAction)
|
if (performStartAction && OnStart())
|
||||||
OnStart();
|
Carousel.AllowSelection = false;
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
@ -415,20 +417,10 @@ namespace osu.Game.Screens.Select
|
|||||||
{
|
{
|
||||||
Logger.Log($"updating selection with beatmap:{beatmap?.ID.ToString() ?? "null"} ruleset:{ruleset?.ID.ToString() ?? "null"}");
|
Logger.Log($"updating selection with beatmap:{beatmap?.ID.ToString() ?? "null"} ruleset:{ruleset?.ID.ToString() ?? "null"}");
|
||||||
|
|
||||||
if (ruleset?.Equals(decoupledRuleset.Value) == false)
|
if (transferRulesetValue())
|
||||||
{
|
{
|
||||||
Logger.Log($"ruleset changed from \"{decoupledRuleset.Value}\" to \"{ruleset}\"");
|
// if the ruleset changed, the rest of the selection update will happen via updateSelectedRuleset.
|
||||||
|
|
||||||
Mods.Value = Array.Empty<Mod>();
|
Mods.Value = Array.Empty<Mod>();
|
||||||
decoupledRuleset.Value = ruleset;
|
|
||||||
|
|
||||||
// force a filter before attempting to change the beatmap.
|
|
||||||
// we may still be in the wrong ruleset as there is a debounce delay on ruleset changes.
|
|
||||||
Carousel.Filter(null, false);
|
|
||||||
|
|
||||||
// Filtering only completes after the carousel runs Update.
|
|
||||||
// If we also have a pending beatmap change we should delay it one frame.
|
|
||||||
selectionChangedDebounce = Schedule(run);
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -519,6 +511,8 @@ namespace osu.Game.Screens.Select
|
|||||||
ModSelect.SelectedMods.Disabled = false;
|
ModSelect.SelectedMods.Disabled = false;
|
||||||
ModSelect.SelectedMods.BindTo(selectedMods);
|
ModSelect.SelectedMods.BindTo(selectedMods);
|
||||||
|
|
||||||
|
Carousel.AllowSelection = true;
|
||||||
|
|
||||||
BeatmapDetails.Leaderboard.RefreshScores();
|
BeatmapDetails.Leaderboard.RefreshScores();
|
||||||
|
|
||||||
Beatmap.Value.Track.Looping = true;
|
Beatmap.Value.Track.Looping = true;
|
||||||
@ -532,8 +526,6 @@ namespace osu.Game.Screens.Select
|
|||||||
music?.Play();
|
music?.Play();
|
||||||
}
|
}
|
||||||
|
|
||||||
base.OnResuming(last);
|
|
||||||
|
|
||||||
this.FadeIn(250);
|
this.FadeIn(250);
|
||||||
|
|
||||||
this.ScaleTo(1, 250, Easing.OutSine);
|
this.ScaleTo(1, 250, Easing.OutSine);
|
||||||
@ -661,20 +653,34 @@ namespace osu.Game.Screens.Select
|
|||||||
|
|
||||||
// manual binding to parent ruleset to allow for delayed load in the incoming direction.
|
// manual binding to parent ruleset to allow for delayed load in the incoming direction.
|
||||||
transferRulesetValue();
|
transferRulesetValue();
|
||||||
|
|
||||||
Ruleset.ValueChanged += r => updateSelectedRuleset(r.NewValue);
|
Ruleset.ValueChanged += r => updateSelectedRuleset(r.NewValue);
|
||||||
|
|
||||||
decoupledRuleset.ValueChanged += r => Ruleset.Value = r.NewValue;
|
decoupledRuleset.ValueChanged += r => Ruleset.Value = r.NewValue;
|
||||||
decoupledRuleset.DisabledChanged += r => Ruleset.Disabled = r;
|
decoupledRuleset.DisabledChanged += r => Ruleset.Disabled = r;
|
||||||
|
|
||||||
Beatmap.BindDisabledChanged(disabled => Carousel.AllowSelection = !disabled, true);
|
|
||||||
Beatmap.BindValueChanged(workingBeatmapChanged);
|
Beatmap.BindValueChanged(workingBeatmapChanged);
|
||||||
|
|
||||||
boundLocalBindables = true;
|
boundLocalBindables = true;
|
||||||
}
|
}
|
||||||
|
|
||||||
private void transferRulesetValue()
|
/// <summary>
|
||||||
|
/// Transfer the game-wide ruleset to the local decoupled ruleset.
|
||||||
|
/// Will immediately run filter operations if required.
|
||||||
|
/// </summary>
|
||||||
|
/// <returns>Whether a transfer occurred.</returns>
|
||||||
|
private bool transferRulesetValue()
|
||||||
{
|
{
|
||||||
|
if (decoupledRuleset.Value?.Equals(Ruleset.Value) == true)
|
||||||
|
return false;
|
||||||
|
|
||||||
|
Logger.Log($"decoupled ruleset transferred (\"{decoupledRuleset.Value}\" -> \"{Ruleset.Value}\"");
|
||||||
rulesetNoDebounce = decoupledRuleset.Value = Ruleset.Value;
|
rulesetNoDebounce = decoupledRuleset.Value = Ruleset.Value;
|
||||||
|
|
||||||
|
// if we have a pending filter operation, we want to run it now.
|
||||||
|
// it could change selection (ie. if the ruleset has been changed).
|
||||||
|
Carousel?.FlushPendingFilterOperations();
|
||||||
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
private void delete(BeatmapSetInfo beatmap)
|
private void delete(BeatmapSetInfo beatmap)
|
||||||
|
@ -33,8 +33,10 @@ namespace osu.Game.Tests.Visual
|
|||||||
}
|
}
|
||||||
|
|
||||||
[SetUpSteps]
|
[SetUpSteps]
|
||||||
public virtual void SetUpSteps()
|
public override void SetUpSteps()
|
||||||
{
|
{
|
||||||
|
base.SetUpSteps();
|
||||||
|
|
||||||
AddStep(ruleset.RulesetInfo.Name, loadPlayer);
|
AddStep(ruleset.RulesetInfo.Name, loadPlayer);
|
||||||
AddUntilStep("player loaded", () => Player.IsLoaded && Player.Alpha == 1);
|
AddUntilStep("player loaded", () => Player.IsLoaded && Player.Alpha == 1);
|
||||||
}
|
}
|
||||||
|
@ -3,6 +3,7 @@
|
|||||||
|
|
||||||
using osu.Framework.Graphics;
|
using osu.Framework.Graphics;
|
||||||
using osu.Framework.Graphics.Containers;
|
using osu.Framework.Graphics.Containers;
|
||||||
|
using osu.Framework.Testing;
|
||||||
using osu.Game.Screens;
|
using osu.Game.Screens;
|
||||||
|
|
||||||
namespace osu.Game.Tests.Visual
|
namespace osu.Game.Tests.Visual
|
||||||
@ -27,11 +28,23 @@ namespace osu.Game.Tests.Visual
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
protected void LoadScreen(OsuScreen screen)
|
protected void LoadScreen(OsuScreen screen) => Stack.Push(screen);
|
||||||
|
|
||||||
|
[SetUpSteps]
|
||||||
|
public virtual void SetUpSteps() => addExitAllScreensStep();
|
||||||
|
|
||||||
|
[TearDownSteps]
|
||||||
|
public void TearDownSteps() => addExitAllScreensStep();
|
||||||
|
|
||||||
|
private void addExitAllScreensStep()
|
||||||
{
|
{
|
||||||
if (Stack.CurrentScreen != null)
|
AddUntilStep("exit all screens", () =>
|
||||||
|
{
|
||||||
|
if (Stack.CurrentScreen == null) return true;
|
||||||
|
|
||||||
Stack.Exit();
|
Stack.Exit();
|
||||||
Stack.Push(screen);
|
return false;
|
||||||
|
});
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -23,7 +23,7 @@
|
|||||||
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite.Core" Version="2.2.6" />
|
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite.Core" Version="2.2.6" />
|
||||||
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
|
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
|
||||||
<PackageReference Include="ppy.osu.Game.Resources" Version="2019.1230.0" />
|
<PackageReference Include="ppy.osu.Game.Resources" Version="2019.1230.0" />
|
||||||
<PackageReference Include="ppy.osu.Framework" Version="2020.130.0" />
|
<PackageReference Include="ppy.osu.Framework" Version="2020.131.0" />
|
||||||
<PackageReference Include="Sentry" Version="1.2.0" />
|
<PackageReference Include="Sentry" Version="1.2.0" />
|
||||||
<PackageReference Include="SharpCompress" Version="0.24.0" />
|
<PackageReference Include="SharpCompress" Version="0.24.0" />
|
||||||
<PackageReference Include="NUnit" Version="3.12.0" />
|
<PackageReference Include="NUnit" Version="3.12.0" />
|
||||||
|
@ -74,7 +74,7 @@
|
|||||||
</ItemGroup>
|
</ItemGroup>
|
||||||
<ItemGroup Label="Package References">
|
<ItemGroup Label="Package References">
|
||||||
<PackageReference Include="ppy.osu.Game.Resources" Version="2019.1230.0" />
|
<PackageReference Include="ppy.osu.Game.Resources" Version="2019.1230.0" />
|
||||||
<PackageReference Include="ppy.osu.Framework.iOS" Version="2020.130.0" />
|
<PackageReference Include="ppy.osu.Framework.iOS" Version="2020.131.0" />
|
||||||
</ItemGroup>
|
</ItemGroup>
|
||||||
<!-- Xamarin.iOS does not automatically handle transitive dependencies from NuGet packages. -->
|
<!-- Xamarin.iOS does not automatically handle transitive dependencies from NuGet packages. -->
|
||||||
<ItemGroup Label="Transitive Dependencies">
|
<ItemGroup Label="Transitive Dependencies">
|
||||||
@ -82,7 +82,7 @@
|
|||||||
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="2.2.6" />
|
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="2.2.6" />
|
||||||
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite.Core" Version="2.2.6" />
|
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite.Core" Version="2.2.6" />
|
||||||
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
|
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
|
||||||
<PackageReference Include="ppy.osu.Framework" Version="2020.130.0" />
|
<PackageReference Include="ppy.osu.Framework" Version="2020.131.0" />
|
||||||
<PackageReference Include="SharpCompress" Version="0.24.0" />
|
<PackageReference Include="SharpCompress" Version="0.24.0" />
|
||||||
<PackageReference Include="NUnit" Version="3.12.0" />
|
<PackageReference Include="NUnit" Version="3.12.0" />
|
||||||
<PackageReference Include="SharpRaven" Version="2.4.0" />
|
<PackageReference Include="SharpRaven" Version="2.4.0" />
|
||||||
|
Loading…
Reference in New Issue
Block a user