h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-13 12:02:54 +08:00
Code Issues Releases Wiki Activity

Reworked reopening last tab to no longer use recursion

Browse Source 
A reviewer of the pull request was concerned about recursion. I changed
the code to be iterative.
This commit is contained in:
Joseph-Ramos-CMU 2020-12-16 12:04:07 -05:00
parent 7b169c4f62
commit 2f8a085adf
1 changed files with 35 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
osu.Game/Online/Chat/ChannelManager.cs
View File

@ -445,33 +445,47 @@ namespace osu.Game.Online.Chat
return;
}
string lastClosedChannelName = closedChannels.Last();
closedChannels.RemoveAt(closedChannels.Count - 1);
// types did not work with existing enumerable interfaces funcitons like Contains
for (int i = 0; i < joinedChannels.Count; i++)
// This nested loop could be eliminated if a check was added so that
// when the code opens a channel it removes from the closedChannel list.
// However, this would require adding an O(|closeChannels|) work operation
// every time the user joins a channel, which would make joining a channel
// slower. I wanted to centralize all major slowdowns so they
// can only occur if the user actually decides to use this feature.
for (int i = closedChannels.Count - 1; i >= 0; i--)
{
// If the user already joined the channel, try the next
// channel in the list
if (joinedChannels[i].Name == lastClosedChannelName)
string lastClosedChannelName = closedChannels.Last();
closedChannels.RemoveAt(closedChannels.Count - 1);
bool alreadyJoined = false;
// If the user already joined the channel, do not
// try to join it
for (int j = 0; j < joinedChannels.Count; j++)
{
JoinLastClosedChannel();
return;
if (joinedChannels[j].Name == lastClosedChannelName)
{
alreadyJoined = true;
break;
}
}
if (alreadyJoined == false)
{
Channel lastClosedChannel = AvailableChannels.FirstOrDefault(c => c.Name == lastClosedChannelName);
if (lastClosedChannel == null)
{
continue;
}
else
{
JoinChannel(lastClosedChannel);
return;
}
}
}
Channel lastClosedChannel = AvailableChannels.FirstOrDefault(c => c.Name == lastClosedChannelName);
if (lastClosedChannel == null)
{
JoinLastClosedChannel();
}
else
{
JoinChannel(lastClosedChannel);
}
}
private long lastMessageId;
private bool channelsInitialised;