h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-08 06:36:05 +08:00
Code Issues Releases Wiki Activity

Avoid ChatAckRequest failures flooding console in OsuGameTestScenes

Browse Source
This commit is contained in:
Dean Herbert 2024-05-30 17:37:55 +09:00
parent 0a7336ef17
commit 2f2bc8e52e
No known key found for this signature in database
3 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Tests/Chat/TestSceneChannelManager.cs
View File

@ -59,7 +59,7 @@ namespace osu.Game.Tests.Chat
return true; return true;
case ChatAckRequest ack: case ChatAckRequest ack:
ack.TriggerSuccess(new ChatAckResponse { Silences = silencedUserIds.Select(u => new ChatSilence { UserId = u }).ToList() }); ack.TriggerSuccess(new ChatAckResponse { Silences = silencedUserIds.Select(u => new ChatSilence { UserId = u }).ToArray() });
silencedUserIds.Clear(); silencedUserIds.Clear();
return true; return true;

8
osu.Game/Online/API/DummyAPIAccess.cs
View File

@ -2,6 +2,7 @@
// See the LICENCE file in the repository root for full licence text. // See the LICENCE file in the repository root for full licence text.
using System; using System;
using System.Collections.Generic;
using System.Threading; using System.Threading;
using System.Threading.Tasks; using System.Threading.Tasks;
using osu.Framework.Bindables; using osu.Framework.Bindables;
@ -84,6 +85,13 @@ namespace osu.Game.Online.API
{ {
if (HandleRequest?.Invoke(request) != true) if (HandleRequest?.Invoke(request) != true)
{ {
// Noisy so let's silently allow these to succeed.
if (request is ChatAckRequest ack)
{
ack.TriggerSuccess(new ChatAckResponse());
return;
}
request.Fail(new InvalidOperationException($@"{nameof(DummyAPIAccess)} cannot process this request.")); request.Fail(new InvalidOperationException($@"{nameof(DummyAPIAccess)} cannot process this request."));
} }
}); });

4
osu.Game/Online/API/Requests/Responses/ChatAckResponse.cs
View File

@ -1,7 +1,7 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence. // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text. // See the LICENCE file in the repository root for full licence text.
using System.Collections.Generic; using System;
using Newtonsoft.Json; using Newtonsoft.Json;
namespace osu.Game.Online.API.Requests.Responses namespace osu.Game.Online.API.Requests.Responses
@ -10,6 +10,6 @@ namespace osu.Game.Online.API.Requests.Responses
public class ChatAckResponse public class ChatAckResponse
{ {
[JsonProperty("silences")] [JsonProperty("silences")]
public List<ChatSilence> Silences { get; set; } = null!; public ChatSilence[] Silences { get; set; } = Array.Empty<ChatSilence>();
} }
} }