From 2d135e5be61e2615fe045747a34c834d31d3c7fb Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Thu, 10 Mar 2022 19:52:08 +0900
Subject: [PATCH] Explain purpose of `Schedule` call in
 `MultiplayerPlayer.onResultsReady`

---
 .../Screens/OnlinePlay/Multiplayer/MultiplayerPlayer.cs   | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerPlayer.cs b/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerPlayer.cs
index b49f373c7b..78e7f3d987 100644
--- a/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerPlayer.cs
+++ b/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerPlayer.cs
@@ -175,10 +175,12 @@ namespace osu.Game.Screens.OnlinePlay.Multiplayer
             base.StartGameplay();
         });
 
-        private void onResultsReady() => Scheduler.Add(() =>
+        private void onResultsReady()
         {
-            resultsReady.SetResult(true);
-        });
+            // Schedule is required to ensure that `TaskCompletionSource.SetResult` is not called more than once.
+            // A scenario where this can occur is if this instance is not immediately disposed (ie. async disposal queue).
+            Schedule(() => resultsReady.SetResult(true));
+        }
 
         protected override async Task PrepareScoreForResultsAsync(Score score)
         {