From 2ceb3f6f85e2d592e7b10794b7949de61ff84d6c Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Tue, 3 Dec 2024 13:43:20 +0900
Subject: [PATCH] Show an ongoing operation when checking for updates

Addresses https://github.com/ppy/osu/discussions/30950.
---
 osu.Game/Localisation/GeneralSettingsStrings.cs           | 5 +++++
 .../Overlays/Settings/Sections/General/UpdateSettings.cs  | 8 ++++++++
 2 files changed, 13 insertions(+)

diff --git a/osu.Game/Localisation/GeneralSettingsStrings.cs b/osu.Game/Localisation/GeneralSettingsStrings.cs
index 42623f4632..83a3af574c 100644
--- a/osu.Game/Localisation/GeneralSettingsStrings.cs
+++ b/osu.Game/Localisation/GeneralSettingsStrings.cs
@@ -44,6 +44,11 @@ namespace osu.Game.Localisation
         /// </summary>
         public static LocalisableString CheckUpdate => new TranslatableString(getKey(@"check_update"), @"Check for updates");
 
+        /// <summary>
+        /// "Checking for updates"
+        /// </summary>
+        public static LocalisableString CheckingForUpdates => new TranslatableString(getKey(@"checking_for_updates"), @"Checking for updates");
+
         /// <summary>
         /// "Open osu! folder"
         /// </summary>
diff --git a/osu.Game/Overlays/Settings/Sections/General/UpdateSettings.cs b/osu.Game/Overlays/Settings/Sections/General/UpdateSettings.cs
index 82cc952e53..53567109e3 100644
--- a/osu.Game/Overlays/Settings/Sections/General/UpdateSettings.cs
+++ b/osu.Game/Overlays/Settings/Sections/General/UpdateSettings.cs
@@ -53,8 +53,16 @@ namespace osu.Game.Overlays.Settings.Sections.General
                     Action = () =>
                     {
                         checkForUpdatesButton.Enabled.Value = false;
+
+                        var checkingNotification = new ProgressNotification { Text = GeneralSettingsStrings.CheckingForUpdates, };
+                        notifications?.Post(checkingNotification);
+
                         Task.Run(updateManager.CheckForUpdateAsync).ContinueWith(task => Schedule(() =>
                         {
+                            // This sequence allows the notification to be immediately dismissed.
+                            checkingNotification.State = ProgressNotificationState.Cancelled;
+                            checkingNotification.Close(false);
+
                             if (!task.GetResultSafely())
                             {
                                 notifications?.Post(new SimpleNotification