From 2cab8f4e8a38f7a2da570cb792bf7ab50efa57d2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= <dach.bartlomiej@gmail.com>
Date: Thu, 19 Dec 2024 15:02:49 +0100
Subject: [PATCH] Add localisation support

---
 .../SkinnableModDisplayStrings.cs             | 49 +++++++++++++++++++
 osu.Game/Screens/Play/HUD/ModDisplay.cs       |  6 +++
 .../Screens/Play/HUD/SkinnableModDisplay.cs   |  8 +--
 3 files changed, 60 insertions(+), 3 deletions(-)
 create mode 100644 osu.Game/Localisation/SkinComponents/SkinnableModDisplayStrings.cs

diff --git a/osu.Game/Localisation/SkinComponents/SkinnableModDisplayStrings.cs b/osu.Game/Localisation/SkinComponents/SkinnableModDisplayStrings.cs
new file mode 100644
index 0000000000..d3e8c0f8c8
--- /dev/null
+++ b/osu.Game/Localisation/SkinComponents/SkinnableModDisplayStrings.cs
@@ -0,0 +1,49 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using osu.Framework.Localisation;
+
+namespace osu.Game.Localisation.SkinComponents
+{
+    public static class SkinnableModDisplayStrings
+    {
+        private const string prefix = @"osu.Game.Resources.Localisation.SkinnableModDisplay";
+
+        /// <summary>
+        /// "Show extended information"
+        /// </summary>
+        public static LocalisableString ShowExtendedInformation => new TranslatableString(getKey(@"show_extended_information"), @"Show extended information");
+
+        /// <summary>
+        /// "Whether to show extended information for each mod."
+        /// </summary>
+        public static LocalisableString ShowExtendedInformationDescription => new TranslatableString(getKey(@"whether_to_show_extended_information"), @"Whether to show extended information for each mod.");
+
+        /// <summary>
+        /// "Expansion mode"
+        /// </summary>
+        public static LocalisableString ExpansionMode => new TranslatableString(getKey(@"expansion_mode"), @"Expansion mode");
+
+        /// <summary>
+        /// "How the mod display expands when interacted with."
+        /// </summary>
+        public static LocalisableString ExpansionModeDescription => new TranslatableString(getKey(@"how_the_mod_display_expands"), @"How the mod display expands when interacted with.");
+
+        /// <summary>
+        /// "Expand on hover"
+        /// </summary>
+        public static LocalisableString ExpandOnHover => new TranslatableString(getKey(@"expand_on_hover"), @"Expand on hover");
+
+        /// <summary>
+        /// "Always contracted"
+        /// </summary>
+        public static LocalisableString AlwaysContracted => new TranslatableString(getKey(@"always_contracted"), @"Always contracted");
+
+        /// <summary>
+        /// "Always expanded"
+        /// </summary>
+        public static LocalisableString AlwaysExpanded => new TranslatableString(getKey(@"always_expanded"), @"Always expanded");
+
+        private static string getKey(string key) => $@"{prefix}:{key}";
+    }
+}
diff --git a/osu.Game/Screens/Play/HUD/ModDisplay.cs b/osu.Game/Screens/Play/HUD/ModDisplay.cs
index 38417fae04..d076d11b1f 100644
--- a/osu.Game/Screens/Play/HUD/ModDisplay.cs
+++ b/osu.Game/Screens/Play/HUD/ModDisplay.cs
@@ -8,7 +8,10 @@ using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
 using osu.Framework.Graphics.UserInterface;
 using osu.Framework.Input.Events;
+using osu.Framework.Localisation;
 using osu.Game.Graphics.Containers;
+using osu.Game.Localisation;
+using osu.Game.Localisation.SkinComponents;
 using osu.Game.Rulesets.Mods;
 using osu.Game.Rulesets.UI;
 using osuTK;
@@ -145,16 +148,19 @@ namespace osu.Game.Screens.Play.HUD
         /// <summary>
         /// The <see cref="ModDisplay"/> will expand only when hovered.
         /// </summary>
+        [LocalisableDescription(typeof(SkinnableModDisplayStrings), nameof(SkinnableModDisplayStrings.ExpandOnHover))]
         ExpandOnHover,
 
         /// <summary>
         /// The <see cref="ModDisplay"/> will always be expanded.
         /// </summary>
+        [LocalisableDescription(typeof(SkinnableModDisplayStrings), nameof(SkinnableModDisplayStrings.AlwaysExpanded))]
         AlwaysExpanded,
 
         /// <summary>
         /// The <see cref="ModDisplay"/> will always be contracted.
         /// </summary>
+        [LocalisableDescription(typeof(SkinnableModDisplayStrings), nameof(SkinnableModDisplayStrings.AlwaysContracted))]
         AlwaysContracted,
     }
 }
diff --git a/osu.Game/Screens/Play/HUD/SkinnableModDisplay.cs b/osu.Game/Screens/Play/HUD/SkinnableModDisplay.cs
index ce4a4e978e..b81b2d1520 100644
--- a/osu.Game/Screens/Play/HUD/SkinnableModDisplay.cs
+++ b/osu.Game/Screens/Play/HUD/SkinnableModDisplay.cs
@@ -9,6 +9,8 @@ using osu.Framework.Graphics.Containers;
 using osu.Game.Configuration;
 using osu.Game.Rulesets.Mods;
 using osu.Game.Skinning;
+using osu.Game.Localisation;
+using osu.Game.Localisation.SkinComponents;
 
 namespace osu.Game.Screens.Play.HUD
 {
@@ -22,11 +24,11 @@ namespace osu.Game.Screens.Play.HUD
         [Resolved]
         private Bindable<IReadOnlyList<Mod>> mods { get; set; } = null!;
 
-        [SettingSource("Show extended info", "Whether to show extended information for each mod.")]
+        [SettingSource(typeof(SkinnableModDisplayStrings), nameof(SkinnableModDisplayStrings.ShowExtendedInformation), nameof(SkinnableModDisplayStrings.ShowExtendedInformationDescription))]
         public Bindable<bool> ShowExtendedInformation { get; } = new Bindable<bool>(true);
 
-        [SettingSource("Expansion mode", "How the mod display expands when interacted with.")]
-        public Bindable<ExpansionMode> ExpansionModeSetting { get; } = new Bindable<ExpansionMode>(ExpansionMode.ExpandOnHover);
+        [SettingSource(typeof(SkinnableModDisplayStrings), nameof(SkinnableModDisplayStrings.ExpansionMode), nameof(SkinnableModDisplayStrings.ExpansionModeDescription))]
+        public Bindable<ExpansionMode> ExpansionModeSetting { get; } = new Bindable<ExpansionMode>();
 
         [BackgroundDependencyLoader]
         private void load()