h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-26 04:43:01 +08:00
Code Issues Releases Wiki Activity

Remove redundant RequiresChildrenUpdate usage

Browse Source 
We are already manually calling `base.UpdateSubTree` when we need to.
Changing this flag is doing nothing and just adds to the complexity of
the implementation.
This commit is contained in:
Dean Herbert 2024-01-18 14:10:16 +09:00
parent bbb5f9b0f2
commit 2afa4c7e1c
No known key found for this signature in database
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Rulesets/UI/FrameStabilityContainer.cs
View File

@ -34,8 +34,6 @@ namespace osu.Game.Rulesets.UI
/// </summary> /// </summary>
internal bool FrameStablePlayback { get; set; } = true; internal bool FrameStablePlayback { get; set; } = true;
protected override bool RequiresChildrenUpdate => base.RequiresChildrenUpdate && state != PlaybackState.NotValid;
private readonly Bindable<bool> isCatchingUp = new Bindable<bool>(); private readonly Bindable<bool> isCatchingUp = new Bindable<bool>();
private readonly Bindable<bool> waitingOnFrames = new Bindable<bool>(); private readonly Bindable<bool> waitingOnFrames = new Bindable<bool>();