From 2abef4ade5d9b7d63a9d1cb2da5172c74aff9e9b Mon Sep 17 00:00:00 2001 From: Dan Balasescu Date: Fri, 15 Sep 2023 18:35:17 +0900 Subject: [PATCH] Expand comment to justify maximising bonus score MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Bartłomiej Dach --- osu.Game.Rulesets.Osu/Difficulty/OsuLegacyScoreSimulator.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/osu.Game.Rulesets.Osu/Difficulty/OsuLegacyScoreSimulator.cs b/osu.Game.Rulesets.Osu/Difficulty/OsuLegacyScoreSimulator.cs index f92bf6f5ea..952ffa5e7a 100644 --- a/osu.Game.Rulesets.Osu/Difficulty/OsuLegacyScoreSimulator.cs +++ b/osu.Game.Rulesets.Osu/Difficulty/OsuLegacyScoreSimulator.cs @@ -131,6 +131,8 @@ namespace osu.Game.Rulesets.Osu.Difficulty const double maximum_rotations_per_second = 477.0 / 60; // Normally, this value depends on the final overall difficulty. For simplicity, we'll only consider the worst case that maximises bonus score. + // As we're primarily concerned with computing the maximum theoretical final score, + // this will have the final effect of slightly underestimating bonus score achieved on stable when converting from score V1. const double minimum_rotations_per_second = 3; double secondsDuration = spinner.Duration / 1000;