From 2a786f9ec0302f3ba39561ae5a5d56a0eafa7fe5 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Sat, 22 Jan 2022 01:49:07 +0900
Subject: [PATCH] Load text only after it comes on screen (and tidy up
 selection handling logic)

---
 osu.Game/Overlays/Music/PlaylistItem.cs | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/osu.Game/Overlays/Music/PlaylistItem.cs b/osu.Game/Overlays/Music/PlaylistItem.cs
index b3b039148b..b31a03a64d 100644
--- a/osu.Game/Overlays/Music/PlaylistItem.cs
+++ b/osu.Game/Overlays/Music/PlaylistItem.cs
@@ -50,12 +50,9 @@ namespace osu.Game.Overlays.Music
             var artist = new RomanisableString(metadata.ArtistUnicode, metadata.Artist);
 
             titlePart = text.AddText(title, sprite => sprite.Font = OsuFont.GetFont(weight: FontWeight.Regular));
-
-            updateSelectionState(true);
             titlePart.DrawablePartsRecreated += _ => updateSelectionState(true);
 
             text.AddText(@"  "); // to separate the title from the artist.
-
             text.AddText(artist, sprite =>
             {
                 sprite.Font = OsuFont.GetFont(size: 14, weight: FontWeight.Bold);
@@ -65,24 +62,31 @@ namespace osu.Game.Overlays.Music
 
             SelectedSet.BindValueChanged(set =>
             {
-                if (set.OldValue?.Equals(Model) != true && set.NewValue?.Equals(Model) != true)
+                bool newSelected = set.NewValue?.Equals(Model) == true;
+
+                if (newSelected == selected)
                     return;
 
+                selected = newSelected;
                 updateSelectionState(false);
-            }, true);
+            });
+
+            updateSelectionState(true);
         }
 
+        private bool selected;
+
         private void updateSelectionState(bool instant)
         {
             foreach (Drawable s in titlePart.Drawables)
-                s.FadeColour(SelectedSet.Value?.Equals(Model) == true ? colours.Yellow : Color4.White, instant ? 0 : FADE_DURATION);
+                s.FadeColour(selected ? colours.Yellow : Color4.White, instant ? 0 : FADE_DURATION);
         }
 
-        protected override Drawable CreateContent() => text = new OsuTextFlowContainer
+        protected override Drawable CreateContent() => new DelayedLoadWrapper(text = new OsuTextFlowContainer
         {
             RelativeSizeAxes = Axes.X,
             AutoSizeAxes = Axes.Y,
-        };
+        });
 
         protected override bool OnClick(ClickEvent e)
         {