h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-05 11:43:01 +08:00
Code Issues Releases Wiki Activity

Fix progress notifications not creating their completion notification early enough

Browse Source 
FIxes notification overlay thinking it has no notifications left and closing.
This commit is contained in:
Dean Herbert 2017-12-27 13:25:42 +09:00
parent c445291be7
commit 2a7147240f
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osu.Game/Overlays/NotificationOverlay.cs
View File

@ -85,9 +85,12 @@ namespace osu.Game.Overlays
private void notificationClosed() private void notificationClosed()
{ {
// hide ourselves if all notifications have been dismissed. Schedule(() =>
if (totalCount == 0) {
State = Visibility.Hidden; // hide ourselves if all notifications have been dismissed.
if (totalCount == 0)
State = Visibility.Hidden;
});
updateCounts(); updateCounts();
} }

2
osu.Game/Overlays/Notifications/ProgressNotification.cs
View File

@ -95,8 +95,8 @@ namespace osu.Game.Overlays.Notifications
protected virtual void Completed() protected virtual void Completed()
{ {
base.Close();
CompletionTarget?.Invoke(CreateCompletionNotification()); CompletionTarget?.Invoke(CreateCompletionNotification());
base.Close();
} }
public override bool DisplayOnTop => false; public override bool DisplayOnTop => false;