h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 03:02:56 +08:00
Code Issues Releases Wiki Activity

Remove daily challenge tooltip from main menu

Browse Source 
Now that we have a nice intro screen for the daily challenge, it's
generally thought that we want to "spoil" the beatmap until the intro is
shown.

Also I was never a huge fan of having a tooltip on a main menu button..
just feels a bit odd.
This commit is contained in:
Dean Herbert 2024-08-14 20:45:27 +09:00
parent 58d9a4adba
commit 28ab65243d
No known key found for this signature in database
1 changed files with 1 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
osu.Game/Screens/Menu/DailyChallengeButton.cs
View File

@ -9,12 +9,10 @@ using osu.Framework.Extensions.ObjectExtensions;
using osu.Framework.Graphics; using osu.Framework.Graphics;
using osu.Framework.Graphics.Colour; using osu.Framework.Graphics.Colour;
using osu.Framework.Graphics.Containers; using osu.Framework.Graphics.Containers;
using osu.Framework.Graphics.Cursor;
using osu.Framework.Graphics.Shapes; using osu.Framework.Graphics.Shapes;
using osu.Framework.Threading; using osu.Framework.Threading;
using osu.Framework.Utils; using osu.Framework.Utils;
using osu.Game.Beatmaps.Drawables; using osu.Game.Beatmaps.Drawables;
using osu.Game.Beatmaps.Drawables.Cards;
using osu.Game.Graphics; using osu.Game.Graphics;
using osu.Game.Graphics.Sprites; using osu.Game.Graphics.Sprites;
using osu.Game.Localisation; using osu.Game.Localisation;
@ -30,7 +28,7 @@ using osuTK.Input;
namespace osu.Game.Screens.Menu namespace osu.Game.Screens.Menu
{ {
public partial class DailyChallengeButton : MainMenuButton, IHasCustomTooltip<APIBeatmapSet?> public partial class DailyChallengeButton : MainMenuButton
{ {
public Room? Room { get; private set; } public Room? Room { get; private set; }
@ -201,36 +199,6 @@ namespace osu.Game.Screens.Menu
base.UpdateState(); base.UpdateState();
} }
public ITooltip<APIBeatmapSet?> GetCustomTooltip() => new DailyChallengeTooltip();
public APIBeatmapSet? TooltipContent { get; private set; } public APIBeatmapSet? TooltipContent { get; private set; }
internal partial class DailyChallengeTooltip : CompositeDrawable, ITooltip<APIBeatmapSet?>
{
[Cached]
private OverlayColourProvider colourProvider = new OverlayColourProvider(OverlayColourScheme.Purple);
private APIBeatmapSet? lastContent;
[BackgroundDependencyLoader]
private void load()
{
AutoSizeAxes = Axes.Both;
}
public void Move(Vector2 pos) => Position = pos;
public void SetContent(APIBeatmapSet? content)
{
if (content == lastContent)
return;
lastContent = content;
ClearInternal();
if (content != null)
AddInternal(new BeatmapCardNano(content));
}
}
} }
} }