From 2761ee005dafb9f2f5eea1c5a958e2c1cdb64bb8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= Date: Fri, 18 Apr 2025 14:23:43 +0200 Subject: [PATCH] Fix storyboard videos not displaying Regressed with 102085668f84bd80f1717f101adc22fc7075e7fa because the stupid magic alpha transform addition was also implicitly changing the value of `IsDrawable` from false to true because that property checks for presence of any commands. Apparently past me, in his infinite wisdom, did not decide it pertinent to test that change against, you know, *a beatmap with a storyboard*. Great job, past me, good show all around. --- osu.Game/Storyboards/StoryboardSprite.cs | 2 +- osu.Game/Storyboards/StoryboardVideo.cs | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/osu.Game/Storyboards/StoryboardSprite.cs b/osu.Game/Storyboards/StoryboardSprite.cs index e10edfefe1..5b3e7c3919 100644 --- a/osu.Game/Storyboards/StoryboardSprite.cs +++ b/osu.Game/Storyboards/StoryboardSprite.cs @@ -17,7 +17,7 @@ namespace osu.Game.Storyboards private readonly List triggerGroups = new List(); public string Path { get; } - public bool IsDrawable => HasCommands; + public virtual bool IsDrawable => HasCommands; public Anchor Origin; public Vector2 InitialPosition; diff --git a/osu.Game/Storyboards/StoryboardVideo.cs b/osu.Game/Storyboards/StoryboardVideo.cs index fb4ac56e98..5a9eb533c6 100644 --- a/osu.Game/Storyboards/StoryboardVideo.cs +++ b/osu.Game/Storyboards/StoryboardVideo.cs @@ -19,6 +19,8 @@ namespace osu.Game.Storyboards public override double StartTime { get; } + public override bool IsDrawable => true; + public override Drawable CreateDrawable() => new DrawableStoryboardVideo(this); } }