h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 02:42:54 +08:00
Code Issues Releases Wiki Activity

Do not rely on unspecified Dictionary.Values ordering

Browse Source
This commit is contained in:
Bartłomiej Dach 2023-05-04 18:26:45 +02:00
parent 0d2396c557
commit 26337dbcd8
No known key found for this signature in database
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Rulesets/Mods/Mod.cs
View File

@ -119,7 +119,11 @@ namespace osu.Game.Rulesets.Mods
/// <summary> /// <summary>
/// All <see cref="IBindable"/> settings within this mod. /// All <see cref="IBindable"/> settings within this mod.
/// </summary> /// </summary>
internal IEnumerable<IBindable> SettingsBindables => Settings.Values; /// <remarks>
/// The settings are returned in ascending key order as per <see cref="Settings"/>.
/// The ordering is intentionally enforced manually, as ordering of <see cref="Dictionary{TKey,TValue}.Values"/> is unspecified.
/// </remarks>
internal IEnumerable<IBindable> SettingsBindables => Settings.OrderBy(pair => pair.Key).Select(pair => pair.Value);
/// <summary> /// <summary>
/// Provides mapping of names to <see cref="IBindable"/>s of all settings within this mod. /// Provides mapping of names to <see cref="IBindable"/>s of all settings within this mod.