From 2127b6ca4e72ff9ff76d098dc1f36ada6b7a0bc5 Mon Sep 17 00:00:00 2001 From: Hivie Date: Wed, 6 Aug 2025 08:42:19 +0100 Subject: [PATCH] use already-existing framework extension method --- .../Edit/Checks/CheckMissingGenreLanguage.cs | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/osu.Game/Rulesets/Edit/Checks/CheckMissingGenreLanguage.cs b/osu.Game/Rulesets/Edit/Checks/CheckMissingGenreLanguage.cs index 4ed536fe7b..b7a727c4d5 100644 --- a/osu.Game/Rulesets/Edit/Checks/CheckMissingGenreLanguage.cs +++ b/osu.Game/Rulesets/Edit/Checks/CheckMissingGenreLanguage.cs @@ -3,9 +3,8 @@ using System; using System.Collections.Generic; -using System.ComponentModel; using System.Linq; -using System.Reflection; +using osu.Framework.Extensions; using osu.Game.Overlays.BeatmapListing; using osu.Game.Rulesets.Edit.Checks.Components; @@ -39,8 +38,7 @@ namespace osu.Game.Rulesets.Edit.Checks { foreach (var value in Enum.GetValues()) { - string description = getGenreLanguageString(value); - string[] words = description.ToLowerInvariant().Split(' '); + string[] words = value.GetDescription().ToLowerInvariant().Split(' '); if (words.All(tags.Contains)) return true; @@ -49,15 +47,6 @@ namespace osu.Game.Rulesets.Edit.Checks return false; } - // "Video Game" and "Hip Hop" are multiple words that are properly formatted in the enum's description attribute, - // so we need to use that and fall back to the enum's string value for the rest. - private string getGenreLanguageString(Enum value) - { - var field = value.GetType().GetField(value.ToString()); - var attribute = field?.GetCustomAttribute(); - return attribute?.Description ?? value.ToString(); - } - public class IssueTemplateMissingGenre : IssueTemplate { public IssueTemplateMissingGenre(ICheck check)