From 20b611486350e69582f7a5a126463f4ad1e78db7 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Tue, 30 Jul 2019 17:52:06 +0900
Subject: [PATCH] Reduce method complexity

---
 osu.Game/Utils/RavenLogger.cs | 54 +++++++++++++++++++----------------
 1 file changed, 30 insertions(+), 24 deletions(-)

diff --git a/osu.Game/Utils/RavenLogger.cs b/osu.Game/Utils/RavenLogger.cs
index 2a396d35cf..6aaf55e045 100644
--- a/osu.Game/Utils/RavenLogger.cs
+++ b/osu.Game/Utils/RavenLogger.cs
@@ -37,35 +37,13 @@ namespace osu.Game.Utils
 
                 if (exception != null)
                 {
-                    switch (exception)
-                    {
-                        case IOException ioe:
-                            // disk full exceptions, see https://stackoverflow.com/a/9294382
-                            const int hr_error_handle_disk_full = unchecked((int)0x80070027);
-                            const int hr_error_disk_full = unchecked((int)0x80070070);
-
-                            if (ioe.HResult == hr_error_handle_disk_full || ioe.HResult == hr_error_disk_full)
-                                return;
-
-                            break;
-
-                        case WebException we:
-                            switch (we.Status)
-                            {
-                                // more statuses may need to be blocked as we come across them.
-                                case WebExceptionStatus.Timeout:
-                                    return;
-                            }
-
-                            break;
-                    }
+                    if (!shouldSubmitException(exception))
+                        return;
 
                     // since we let unhandled exceptions go ignored at times, we want to ensure they don't get submitted on subsequent reports.
                     if (lastException != null &&
                         lastException.Message == exception.Message && exception.StackTrace.StartsWith(lastException.StackTrace))
-                    {
                         return;
-                    }
 
                     lastException = exception;
                     queuePendingTask(raven.CaptureAsync(new SentryEvent(exception)));
@@ -75,6 +53,34 @@ namespace osu.Game.Utils
             };
         }
 
+        private bool shouldSubmitException(Exception exception)
+        {
+            switch (exception)
+            {
+                case IOException ioe:
+                    // disk full exceptions, see https://stackoverflow.com/a/9294382
+                    const int hr_error_handle_disk_full = unchecked((int)0x80070027);
+                    const int hr_error_disk_full = unchecked((int)0x80070070);
+
+                    if (ioe.HResult == hr_error_handle_disk_full || ioe.HResult == hr_error_disk_full)
+                        return false;
+
+                    break;
+
+                case WebException we:
+                    switch (we.Status)
+                    {
+                        // more statuses may need to be blocked as we come across them.
+                        case WebExceptionStatus.Timeout:
+                            return false;
+                    }
+
+                    break;
+            }
+
+            return true;
+        }
+
         private void queuePendingTask(Task<string> task)
         {
             lock (tasks) tasks.Add(task);