From 205eda8566baf7566d5b315112e0d33ce47cd5e0 Mon Sep 17 00:00:00 2001
From: Huo Yaoyuan <huoyaoyuan@hotmail.com>
Date: Tue, 12 Nov 2019 18:30:25 +0800
Subject: [PATCH] Use readonly field when not reflected.

---
 .editorconfig                                               | 3 +--
 osu.Game.Tests/NonVisual/Filtering/FilterQueryParserTest.cs | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/.editorconfig b/.editorconfig
index a555a3d2bc..92d06da4f3 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -158,6 +158,7 @@ csharp_style_throw_expression = true:silent
 csharp_style_conditional_delegate_call = true:suggestion
 
 #Style - unused
+dotnet_style_readonly_field = true:silent
 dotnet_code_quality_unused_parameters = non_public:silent
 csharp_style_unused_value_expression_statement_preference = discard_variable:silent
 csharp_style_unused_value_assignment_preference = discard_variable:suggestion
@@ -175,8 +176,6 @@ dotnet_style_prefer_is_null_check_over_reference_equality_method = true:silent
 #Supressing roslyn built-in analyzers
 # Suppress: EC112
 
-#Field can be readonly
-dotnet_diagnostic.IDE0044.severity = silent
 #Private method is unused
 dotnet_diagnostic.IDE0051.severity = silent
 #Private member is unused
diff --git a/osu.Game.Tests/NonVisual/Filtering/FilterQueryParserTest.cs b/osu.Game.Tests/NonVisual/Filtering/FilterQueryParserTest.cs
index 9869ddde41..7b2913b817 100644
--- a/osu.Game.Tests/NonVisual/Filtering/FilterQueryParserTest.cs
+++ b/osu.Game.Tests/NonVisual/Filtering/FilterQueryParserTest.cs
@@ -87,7 +87,7 @@ namespace osu.Game.Tests.NonVisual.Filtering
             Assert.IsNull(filterCriteria.BPM.Max);
         }
 
-        private static object[] lengthQueryExamples =
+        private static readonly object[] length_query_examples =
         {
             new object[] { "6ms", TimeSpan.FromMilliseconds(6), TimeSpan.FromMilliseconds(1) },
             new object[] { "23s", TimeSpan.FromSeconds(23), TimeSpan.FromSeconds(1) },
@@ -97,7 +97,7 @@ namespace osu.Game.Tests.NonVisual.Filtering
         };
 
         [Test]
-        [TestCaseSource(nameof(lengthQueryExamples))]
+        [TestCaseSource(nameof(length_query_examples))]
         public void TestApplyLengthQueries(string lengthQuery, TimeSpan expectedLength, TimeSpan scale)
         {
             string query = $"length={lengthQuery} time";