From 1ff77754fd9f1e40709b3a547ca090fcef07ef76 Mon Sep 17 00:00:00 2001
From: PercyDan54 <50285552+PercyDan54@users.noreply.github.com>
Date: Fri, 2 Apr 2021 20:14:31 +0800
Subject: [PATCH] Use OnlineViewContainer

---
 .../Visual/SongSelect/TestSceneBeatmapDetails.cs   |  5 +++++
 osu.Game/Screens/Select/BeatmapDetails.cs          | 14 +++++++-------
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapDetails.cs b/osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapDetails.cs
index acf037198f..06572f66bf 100644
--- a/osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapDetails.cs
+++ b/osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapDetails.cs
@@ -5,6 +5,7 @@ using System.Linq;
 using NUnit.Framework;
 using osu.Framework.Graphics;
 using osu.Game.Beatmaps;
+using osu.Game.Online.API;
 using osu.Game.Screens.Select;
 
 namespace osu.Game.Tests.Visual.SongSelect
@@ -14,6 +15,8 @@ namespace osu.Game.Tests.Visual.SongSelect
     {
         private BeatmapDetails details;
 
+        private DummyAPIAccess api => (DummyAPIAccess)API;
+
         [SetUp]
         public void Setup() => Schedule(() =>
         {
@@ -173,6 +176,8 @@ namespace osu.Game.Tests.Visual.SongSelect
             {
                 OnlineBeatmapID = 162,
             });
+            AddStep("set online", () => api.SetState(APIState.Online));
+            AddStep("set offline", () => api.SetState(APIState.Offline));
         }
     }
 }
diff --git a/osu.Game/Screens/Select/BeatmapDetails.cs b/osu.Game/Screens/Select/BeatmapDetails.cs
index 8a1c291fca..55616b1640 100644
--- a/osu.Game/Screens/Select/BeatmapDetails.cs
+++ b/osu.Game/Screens/Select/BeatmapDetails.cs
@@ -19,6 +19,7 @@ using osu.Game.Graphics.Containers;
 using osu.Game.Graphics.UserInterface;
 using osu.Game.Online.API.Requests;
 using osu.Game.Rulesets;
+using osu.Game.Online;
 
 namespace osu.Game.Screens.Select
 {
@@ -136,7 +137,7 @@ namespace osu.Game.Screens.Select
                                 },
                             },
                         },
-                        failRetryContainer = new Container
+                        failRetryContainer = new OnlineViewContainer("Sign in to view more details")
                         {
                             Anchor = Anchor.BottomLeft,
                             Origin = Anchor.BottomLeft,
@@ -153,11 +154,11 @@ namespace osu.Game.Screens.Select
                                     RelativeSizeAxes = Axes.Both,
                                     Padding = new MarginPadding { Top = 14 + spacing / 2 },
                                 },
+                                loading = new LoadingLayer(true)
                             },
                         },
                     },
                 },
-                loading = new LoadingLayer(true),
             };
         }
 
@@ -222,11 +223,9 @@ namespace osu.Game.Screens.Select
                     if (beatmap != requestedBeatmap)
                         // the beatmap has been changed since we started the lookup.
                         return;
-
                     updateMetrics();
                 });
             };
-
             api.Queue(lookup);
             loading.Show();
         }
@@ -236,7 +235,9 @@ namespace osu.Game.Screens.Select
             var hasRatings = beatmap?.BeatmapSet?.Metrics?.Ratings?.Any() ?? false;
             var hasRetriesFails = (beatmap?.Metrics?.Retries?.Any() ?? false) || (beatmap?.Metrics?.Fails?.Any() ?? false);
 
-            if (hasRatings)
+            bool isOnline = api.State.Value == APIState.Online;
+
+            if (hasRatings && isOnline)
             {
                 ratings.Metrics = beatmap.BeatmapSet.Metrics;
                 ratingsContainer.FadeIn(transition_duration);
@@ -244,7 +245,7 @@ namespace osu.Game.Screens.Select
             else
             {
                 ratings.Metrics = new BeatmapSetMetrics { Ratings = new int[10] };
-                ratingsContainer.FadeTo(0.25f, transition_duration);
+                ratingsContainer.FadeTo(isOnline ? 0.25f : 0, transition_duration);
             }
 
             if (hasRetriesFails)
@@ -259,7 +260,6 @@ namespace osu.Game.Screens.Select
                     Fails = new int[100],
                     Retries = new int[100],
                 };
-                failRetryContainer.FadeOut(transition_duration);
             }
 
             loading.Hide();