h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-15 00:13:19 +08:00
Code Issues Releases Wiki Activity

Fix potentially incorrect button being pressed during PopupDialog hide due to flag set too late

Browse Source
This commit is contained in:
Dean Herbert 2022-04-14 17:51:50 +09:00
parent 58d5cf4560
commit 1fdf742d38
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game/Overlays/Dialog/PopupDialog.cs
View File

@ -87,12 +87,13 @@ namespace osu.Game.Overlays.Dialog
{ {
if (actionInvoked) return; if (actionInvoked) return;
actionInvoked = true;
// Hide the dialog before running the action. // Hide the dialog before running the action.
// This is important as the code which is performed may check for a dialog being present (ie. `OsuGame.PerformFromScreen`) // This is important as the code which is performed may check for a dialog being present (ie. `OsuGame.PerformFromScreen`)
// and we don't want it to see the already dismissed dialog. // and we don't want it to see the already dismissed dialog.
Hide(); Hide();
actionInvoked = true;
action?.Invoke(); action?.Invoke();
}; };
} }