h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-05 00:23:21 +08:00
Code Issues Releases Wiki Activity

Move all PlaylistResultScreen test state initialisation into SetUpSteps

Browse Source
This commit is contained in:
Jai Sharma 2022-03-15 22:15:35 +00:00
parent c56df80106
commit 1c79083f96
1 changed files with 18 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
osu.Game.Tests/Visual/Playlists/TestScenePlaylistsResultsScreen.cs
View File

@ -40,32 +40,30 @@ namespace osu.Game.Tests.Visual.Playlists
private int totalCount; private int totalCount;
private ScoreInfo userScore; private ScoreInfo userScore;
[SetUp]
public void Setup() => Schedule(() =>
{
lowestScoreId = 1;
highestScoreId = 1;
requestComplete = false;
totalCount = 0;
userScore = TestResources.CreateTestScoreInfo();
userScore.TotalScore = 0;
userScore.Statistics = new Dictionary<HitResult, int>();
bindHandler();
});
[SetUpSteps] [SetUpSteps]
public override void SetUpSteps() public override void SetUpSteps()
{ {
base.SetUpSteps(); base.SetUpSteps();
// Existing test instances of the results screen hold a leased bindable of the beatmap, // Previous test instances of the results screen may still exist at this point so wait for
// so wait for those screens to be cleaned up by the base SetUpSteps before re-assigning // those screens to be cleaned up by the base SetUpSteps before re-initialising test state.
AddStep("Create Working Beatmap", () => // The the screen also holds a leased Beatmap bindable so reassigning it must happen after
// the screen as been exited.
AddStep("initialise user scores and beatmap", () =>
{ {
// Beatmap is required to be an actual beatmap so the scores can get their scores correctly calculated for standardised scoring. lowestScoreId = 1;
// else the tests that rely on ordering will fall over. highestScoreId = 1;
requestComplete = false;
totalCount = 0;
userScore = TestResources.CreateTestScoreInfo();
userScore.TotalScore = 0;
userScore.Statistics = new Dictionary<HitResult, int>();
bindHandler();
// Beatmap is required to be an actual beatmap so the scores can get their scores correctly
// calculated for standardised scoring, else the tests that rely on ordering will fall over.
Beatmap.Value = CreateWorkingBeatmap(Ruleset.Value); Beatmap.Value = CreateWorkingBeatmap(Ruleset.Value);
}); });
} }