From 8506da725dcf0aac225bd6ab5c230fb0150827e3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= <dach.bartlomiej@gmail.com>
Date: Mon, 15 Apr 2024 11:49:47 +0200
Subject: [PATCH 1/2] Add failing test

---
 .../TestSceneExpandedPanelMiddleContent.cs        | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/osu.Game.Tests/Visual/Ranking/TestSceneExpandedPanelMiddleContent.cs b/osu.Game.Tests/Visual/Ranking/TestSceneExpandedPanelMiddleContent.cs
index 9f7726313a..02a321d22f 100644
--- a/osu.Game.Tests/Visual/Ranking/TestSceneExpandedPanelMiddleContent.cs
+++ b/osu.Game.Tests/Visual/Ranking/TestSceneExpandedPanelMiddleContent.cs
@@ -104,6 +104,21 @@ namespace osu.Game.Tests.Visual.Ranking
             });
         }
 
+        [Test]
+        public void TestPPNotShownAsProvisionalIfClassicModIsPresentDueToLegacyScore()
+        {
+            AddStep("show example score", () =>
+            {
+                var score = TestResources.CreateTestScoreInfo(createTestBeatmap(new RealmUser()));
+                score.PP = 400;
+                score.Mods = score.Mods.Append(new OsuModClassic()).ToArray();
+                score.IsLegacyScore = true;
+                showPanel(score);
+            });
+
+            AddAssert("pp display faded out", () => this.ChildrenOfType<PerformanceStatistic>().Single().Alpha == 1);
+        }
+
         [Test]
         public void TestWithDefaultDate()
         {

From 7c4c8ee75c746620f955f1fbb2b1e43f26badf4a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= <dach.bartlomiej@gmail.com>
Date: Mon, 15 Apr 2024 11:53:03 +0200
Subject: [PATCH 2/2] Fix stable scores showing with faded out pp display due
 to classic mod presence

---
 .../Expanded/Statistics/PerformanceStatistic.cs    | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/osu.Game/Screens/Ranking/Expanded/Statistics/PerformanceStatistic.cs b/osu.Game/Screens/Ranking/Expanded/Statistics/PerformanceStatistic.cs
index 0a9c68eafc..8366f8d7ef 100644
--- a/osu.Game/Screens/Ranking/Expanded/Statistics/PerformanceStatistic.cs
+++ b/osu.Game/Screens/Ranking/Expanded/Statistics/PerformanceStatistic.cs
@@ -4,6 +4,7 @@
 #nullable disable
 
 using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
@@ -17,6 +18,7 @@ using osu.Game.Graphics.UserInterface;
 using osu.Game.Resources.Localisation.Web;
 using osu.Game.Scoring;
 using osu.Game.Localisation;
+using osu.Game.Rulesets.Mods;
 
 namespace osu.Game.Screens.Ranking.Expanded.Statistics
 {
@@ -74,7 +76,7 @@ namespace osu.Game.Screens.Ranking.Expanded.Statistics
                     Alpha = 0.5f;
                     TooltipText = ResultsScreenStrings.NoPPForUnrankedBeatmaps;
                 }
-                else if (scoreInfo.Mods.Any(m => !m.Ranked))
+                else if (hasUnrankedMods(scoreInfo))
                 {
                     Alpha = 0.5f;
                     TooltipText = ResultsScreenStrings.NoPPForUnrankedMods;
@@ -87,6 +89,16 @@ namespace osu.Game.Screens.Ranking.Expanded.Statistics
             }
         }
 
+        private static bool hasUnrankedMods(ScoreInfo scoreInfo)
+        {
+            IEnumerable<Mod> modsToCheck = scoreInfo.Mods;
+
+            if (scoreInfo.IsLegacyScore)
+                modsToCheck = modsToCheck.Where(m => m is not ModClassic);
+
+            return modsToCheck.Any(m => !m.Ranked);
+        }
+
         public override void Appear()
         {
             base.Appear();