1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-12 19:03:08 +08:00

Add comment covering intentional call to ClearTransformsAfter

This commit is contained in:
Dean Herbert 2020-11-23 15:18:54 +09:00
parent 9f997db958
commit 19faa2b9bb
2 changed files with 4 additions and 0 deletions

View File

@ -149,8 +149,10 @@ namespace osu.Game.Rulesets.Judgements
private void runAnimation() private void runAnimation()
{ {
// undo any transforms applies in ApplyMissAnimations/ApplyHitAnimations to get a sane initial state.
ApplyTransformsAt(double.MinValue, true); ApplyTransformsAt(double.MinValue, true);
ClearTransforms(true); ClearTransforms(true);
LifetimeStart = Result.TimeAbsolute; LifetimeStart = Result.TimeAbsolute;
using (BeginAbsoluteSequence(Result.TimeAbsolute, true)) using (BeginAbsoluteSequence(Result.TimeAbsolute, true))

View File

@ -439,6 +439,8 @@ namespace osu.Game.Rulesets.Objects.Drawables
private void clearExistingStateTransforms() private void clearExistingStateTransforms()
{ {
base.ApplyTransformsAt(double.MinValue, true); base.ApplyTransformsAt(double.MinValue, true);
// has to call this method directly (not ClearTransforms) to bypass the local ClearTransformsAfter override.
base.ClearTransformsAfter(double.MinValue, true); base.ClearTransformsAfter(double.MinValue, true);
} }