h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-14 00:42:55 +08:00
Code Issues Releases Wiki Activity

Remove "Opacity" setting

Browse Source 
This should be implemented at a higher level
This commit is contained in:
Dean Herbert 2022-09-22 15:19:00 +09:00
parent f3898da37a
commit 19db7c5977
2 changed files with 0 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
osu.Game.Tests/Visual/Gameplay/TestSceneColourHitErrorMeter.cs
View File

@ -32,12 +32,6 @@ namespace osu.Game.Tests.Visual.Gameplay
public TestSceneColourHitErrorMeter() public TestSceneColourHitErrorMeter()
{ {
AddSliderStep("Manual Opacity test", 0.01f, 1, 1, alpha =>
{
if (colourHitErrorMeter.IsNotNull())
colourHitErrorMeter.HitShapeOpacity.Value = alpha;
});
AddSliderStep("Manual spacing test", 0, 10, 2, spacing => AddSliderStep("Manual spacing test", 0, 10, 2, spacing =>
{ {
if (colourHitErrorMeter.IsNotNull()) if (colourHitErrorMeter.IsNotNull())
@ -75,14 +69,6 @@ namespace osu.Game.Tests.Visual.Gameplay
protected override Ruleset CreateRuleset() => new OsuRuleset(); protected override Ruleset CreateRuleset() => new OsuRuleset();
[Test]
public void TestOpacityChange()
{
AddRepeatStep("Add judgement", applyOneJudgement, 5);
AddStep("Change opacity to 30%", () => colourHitErrorMeter.HitShapeOpacity.Value = 0.3f);
AddRepeatStep("Add judgement", applyOneJudgement, 5);
}
[Test] [Test]
public void TestSpacingChange() public void TestSpacingChange()
{ {

9
osu.Game/Screens/Play/HUD/HitErrorMeters/ColourHitErrorMeter.cs
View File

@ -28,14 +28,6 @@ namespace osu.Game.Screens.Play.HUD.HitErrorMeters
Precision = 1 Precision = 1
}; };
[SettingSource("Opacity", "Visibility of the displayed judgements")]
public BindableNumber<float> HitShapeOpacity { get; } = new BindableNumber<float>(1)
{
MinValue = 0.01f,
MaxValue = 1,
Precision = 0.01f,
};
[SettingSource("Spacing", "Space between each displayed judgement")] [SettingSource("Spacing", "Space between each displayed judgement")]
public BindableNumber<float> HitShapeSpacing { get; } = new BindableNumber<float>(2) public BindableNumber<float> HitShapeSpacing { get; } = new BindableNumber<float>(2)
{ {
@ -66,7 +58,6 @@ namespace osu.Game.Screens.Play.HUD.HitErrorMeters
protected override void LoadComplete() protected override void LoadComplete()
{ {
base.LoadComplete(); base.LoadComplete();
HitShapeOpacity.BindValueChanged(_ => judgementsFlow.Alpha = HitShapeOpacity.Value, true);
HitShapeSpacing.BindValueChanged(_ => HitShapeSpacing.BindValueChanged(_ =>
{ {
judgementsFlow.Height = JudgementCount.Value * (drawable_judgement_size + HitShapeSpacing.Value) - HitShapeSpacing.Value; judgementsFlow.Height = JudgementCount.Value * (drawable_judgement_size + HitShapeSpacing.Value) - HitShapeSpacing.Value;