h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-21 20:12:57 +08:00
Code Issues Releases Wiki Activity

Fix timeline not updating ticks correctly after arbitrary timing control point changes

Browse Source
This commit is contained in:
Dean Herbert 2020-12-01 16:44:08 +09:00
parent 6b79d96517
commit 190c6ef45e
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
osu.Game/Screens/Edit/Compose/Components/Timeline/TimelineTickDisplay.cs
View File

@ -25,6 +25,9 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
[Resolved] [Resolved]
private BindableBeatDivisor beatDivisor { get; set; } private BindableBeatDivisor beatDivisor { get; set; }
[Resolved]
private IEditorChangeHandler changeHandler { get; set; }
[Resolved] [Resolved]
private OsuColour colours { get; set; } private OsuColour colours { get; set; }
@ -38,7 +41,15 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
[BackgroundDependencyLoader] [BackgroundDependencyLoader]
private void load() private void load()
{ {
beatDivisor.BindValueChanged(_ => tickCache.Invalidate()); beatDivisor.BindValueChanged(_ => invalidateTicks());
// currently this is the best way to handle any kind of timing changes.
changeHandler.OnStateChange += invalidateTicks;
}
private void invalidateTicks()
{
tickCache.Invalidate();
} }
/// <summary> /// <summary>
@ -165,5 +176,13 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
return point; return point;
} }
} }
protected override void Dispose(bool isDisposing)
{
base.Dispose(isDisposing);
if (changeHandler != null)
changeHandler.OnStateChange -= invalidateTicks;
}
} }
} }