h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-13 15:52:54 +08:00
Code Issues Releases Wiki Activity

Update mod columns even if they're not present/offscreen

Browse Source 
Important to make "select/deselect all" operations work on all columns
simultaneously, even if they're offscreen. Unfortunately by the nature
of how the existing selection animation works, it is hard-tied to the
update loop, so we need to compensate.
This commit is contained in:
Bartłomiej Dach 2022-05-06 18:08:11 +02:00
parent 9514a5cef7
commit 18e4c3ed0f
No known key found for this signature in database
GPG Key ID: BCECCD4FA41F6497
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Overlays/Mods/ModColumn.cs
View File

@ -399,7 +399,7 @@ namespace osu.Game.Overlays.Mods
private readonly Queue<Action> pendingSelectionOperations = new Queue<Action>(); private readonly Queue<Action> pendingSelectionOperations = new Queue<Action>();
protected bool SelectionAnimationRunning => pendingSelectionOperations.Count > 0; internal bool SelectionAnimationRunning => pendingSelectionOperations.Count > 0;
protected override void Update() protected override void Update()
{ {

2
osu.Game/Overlays/Mods/ModSelectScreen.cs
View File

@ -454,6 +454,8 @@ namespace osu.Game.Overlays.Mods
FinishTransforms(); FinishTransforms();
} }
protected override bool RequiresChildrenUpdate => base.RequiresChildrenUpdate || Column.SelectionAnimationRunning;
private void updateDim() private void updateDim()
{ {
Colour4 targetColour; Colour4 targetColour;