h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-09-21 15:27:24 +08:00
Code Issues Releases Wiki Activity

Refactor if/else as ternary conditional

Browse Source
This commit is contained in:
kstefanowicz 2024-08-20 08:36:08 -04:00
parent 730f198c45
commit 18dc375fe9
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs
View File

@ -220,18 +220,13 @@ namespace osu.Game.Beatmaps.Formats
var samplePoint = legacyControlPoints.SamplePointAt(group.Time);
var effectPoint = legacyControlPoints.EffectPointAt(group.Time);
// if samplePoint isn't already legacy,create LegacyHitSampleInfo with customSampleBank 1
HitSampleInfo tempHitSample;
if (samplePoint.GetType() == typeof(SampleControlPoint))
{
tempHitSample = samplePoint.ApplyTo(new ConvertHitObjectParser.LegacyHitSampleInfo(string.Empty, customSampleBank: 1));
}
// if samplePoint isn't already legacy, create LegacyHitSampleInfo with customSampleBank 1
// else create LegacyHitSampleInfo with existing customSampleBank
else
{
tempHitSample = samplePoint.ApplyTo(new ConvertHitObjectParser.LegacyHitSampleInfo(string.Empty));
}
HitSampleInfo tempHitSample = samplePoint.ApplyTo(
samplePoint.GetType() == typeof(SampleControlPoint)
? new ConvertHitObjectParser.LegacyHitSampleInfo(string.Empty, customSampleBank: 1)
: new ConvertHitObjectParser.LegacyHitSampleInfo(string.Empty)
);
// Apply the control point to a hit sample to uncover legacy properties (e.g. suffix)
int customSampleBank = toLegacyCustomSampleBank(tempHitSample);