h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-12 19:03:08 +08:00
Code Issues Releases Wiki Activity

Use StringSplitOptions.TrimEntries for string.Split() when possible

Browse Source
This commit is contained in:
Berkan Diler 2022-12-27 09:41:58 +01:00
parent 38a674cd84
commit 182f36c434
2 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game.Tournament/Screens/Drawings/Components/StorageBackedTeamList.cs
View File

@ -45,7 +45,7 @@ namespace osu.Game.Tournament.Screens.Drawings.Components
continue; continue;
// ReSharper disable once PossibleNullReferenceException // ReSharper disable once PossibleNullReferenceException
string[] split = line.Split(':'); string[] split = line.Split(':', StringSplitOptions.TrimEntries);
if (split.Length < 2) if (split.Length < 2)
{ {
@ -55,9 +55,9 @@ namespace osu.Game.Tournament.Screens.Drawings.Components
teams.Add(new TournamentTeam teams.Add(new TournamentTeam
{ {
FullName = { Value = split[1].Trim(), }, FullName = { Value = split[1], },
Acronym = { Value = split.Length >= 3 ? split[2].Trim() : null, }, Acronym = { Value = split.Length >= 3 ? split[2] : null, },
FlagName = { Value = split[0].Trim() } FlagName = { Value = split[0] }
}); });
} }
} }

8
osu.Game/Beatmaps/Formats/LegacyDecoder.cs
View File

@ -132,13 +132,7 @@ namespace osu.Game.Beatmaps.Formats
protected KeyValuePair<string, string> SplitKeyVal(string line, char separator = ':', bool shouldTrim = true) protected KeyValuePair<string, string> SplitKeyVal(string line, char separator = ':', bool shouldTrim = true)
{ {
string[] split = line.Split(separator, 2); string[] split = line.Split(separator, 2, shouldTrim ? StringSplitOptions.TrimEntries : StringSplitOptions.None);
if (shouldTrim)
{
for (int i = 0; i < split.Length; i++)
split[i] = split[i].Trim();
}
return new KeyValuePair<string, string> return new KeyValuePair<string, string>
( (