h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-14 00:42:55 +08:00
Code Issues Releases Wiki Activity

Always set progress before updating download state

Browse Source 
Without doing so, a state change may read from an old progress value.
This commit is contained in:
Dean Herbert 2021-03-26 14:04:09 +09:00
parent 51ab1dace4
commit 17a0b19ee7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Online/DownloadTrackingComposite.cs
View File

@ -123,13 +123,13 @@ namespace osu.Game.Online
{ {
if (attachedRequest.Progress == 1) if (attachedRequest.Progress == 1)
{ {
State.Value = DownloadState.Importing;
Progress.Value = 1; Progress.Value = 1;
State.Value = DownloadState.Importing;
} }
else else
{ {
State.Value = DownloadState.Downloading;
Progress.Value = attachedRequest.Progress; Progress.Value = attachedRequest.Progress;
State.Value = DownloadState.Downloading;
attachedRequest.Failure += onRequestFailure; attachedRequest.Failure += onRequestFailure;
attachedRequest.DownloadProgressed += onRequestProgress; attachedRequest.DownloadProgressed += onRequestProgress;