h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 11:27:24 +08:00
Code Issues Releases Wiki Activity

Adjust test coverage to cover desired copy naming scheme

Browse Source
This commit is contained in:
Bartłomiej Dach 2022-02-14 19:59:54 +01:00
parent 40cfee3421
commit 1685e214d3
No known key found for this signature in database
GPG Key ID: BCECCD4FA41F6497
1 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
osu.Game.Tests/Visual/Editing/TestSceneEditorBeatmapCreation.cs
View File

@ -172,10 +172,10 @@ namespace osu.Game.Tests.Visual.Editing
[Test] [Test]
public void TestCopyDifficulty() public void TestCopyDifficulty()
{ {
string firstDifficultyName = Guid.NewGuid().ToString(); string originalDifficultyName = Guid.NewGuid().ToString();
string secondDifficultyName = Guid.NewGuid().ToString(); string copyDifficultyName = $"{originalDifficultyName} (copy)";
AddStep("set unique difficulty name", () => EditorBeatmap.BeatmapInfo.DifficultyName = firstDifficultyName); AddStep("set unique difficulty name", () => EditorBeatmap.BeatmapInfo.DifficultyName = originalDifficultyName);
AddStep("add timing point", () => EditorBeatmap.ControlPointInfo.Add(0, new TimingControlPoint { BeatLength = 1000 })); AddStep("add timing point", () => EditorBeatmap.ControlPointInfo.Add(0, new TimingControlPoint { BeatLength = 1000 }));
AddStep("add hitobjects", () => EditorBeatmap.AddRange(new[] AddStep("add hitobjects", () => EditorBeatmap.AddRange(new[]
{ {
@ -210,11 +210,11 @@ namespace osu.Game.Tests.Visual.Editing
AddStep("save beatmap", () => Editor.Save()); AddStep("save beatmap", () => Editor.Save());
AddAssert("new beatmap persisted", () => AddAssert("new beatmap persisted", () =>
{ {
var beatmap = beatmapManager.QueryBeatmap(b => b.DifficultyName == firstDifficultyName); var beatmap = beatmapManager.QueryBeatmap(b => b.DifficultyName == originalDifficultyName);
var set = beatmapManager.QueryBeatmapSet(s => s.ID == EditorBeatmap.BeatmapInfo.BeatmapSet.ID); var set = beatmapManager.QueryBeatmapSet(s => s.ID == EditorBeatmap.BeatmapInfo.BeatmapSet.ID);
return beatmap != null return beatmap != null
&& beatmap.DifficultyName == firstDifficultyName && beatmap.DifficultyName == originalDifficultyName
&& set != null && set != null
&& set.PerformRead(s => s.Beatmaps.Single().ID == beatmap.ID); && set.PerformRead(s => s.Beatmaps.Single().ID == beatmap.ID);
}); });
@ -228,9 +228,10 @@ namespace osu.Game.Tests.Visual.Editing
AddUntilStep("wait for created", () => AddUntilStep("wait for created", () =>
{ {
string difficultyName = Editor.ChildrenOfType<EditorBeatmap>().SingleOrDefault()?.BeatmapInfo.DifficultyName; string difficultyName = Editor.ChildrenOfType<EditorBeatmap>().SingleOrDefault()?.BeatmapInfo.DifficultyName;
return difficultyName != null && difficultyName != firstDifficultyName; return difficultyName != null && difficultyName != originalDifficultyName;
}); });
AddAssert("created difficulty has copy suffix in name", () => EditorBeatmap.BeatmapInfo.DifficultyName == copyDifficultyName);
AddAssert("created difficulty has timing point", () => AddAssert("created difficulty has timing point", () =>
{ {
var timingPoint = EditorBeatmap.ControlPointInfo.TimingPoints.Single(); var timingPoint = EditorBeatmap.ControlPointInfo.TimingPoints.Single();
@ -243,7 +244,6 @@ namespace osu.Game.Tests.Visual.Editing
AddAssert("status not copied", () => EditorBeatmap.BeatmapInfo.Status == BeatmapOnlineStatus.None); AddAssert("status not copied", () => EditorBeatmap.BeatmapInfo.Status == BeatmapOnlineStatus.None);
AddAssert("online ID not copied", () => EditorBeatmap.BeatmapInfo.OnlineID == -1); AddAssert("online ID not copied", () => EditorBeatmap.BeatmapInfo.OnlineID == -1);
AddStep("set unique difficulty name", () => EditorBeatmap.BeatmapInfo.DifficultyName = secondDifficultyName);
AddStep("save beatmap", () => Editor.Save()); AddStep("save beatmap", () => Editor.Save());
BeatmapInfo refetchedBeatmap = null; BeatmapInfo refetchedBeatmap = null;
@ -251,16 +251,19 @@ namespace osu.Game.Tests.Visual.Editing
AddStep("refetch from database", () => AddStep("refetch from database", () =>
{ {
refetchedBeatmap = beatmapManager.QueryBeatmap(b => b.DifficultyName == secondDifficultyName); refetchedBeatmap = beatmapManager.QueryBeatmap(b => b.DifficultyName == copyDifficultyName);
refetchedBeatmapSet = beatmapManager.QueryBeatmapSet(s => s.ID == EditorBeatmap.BeatmapInfo.BeatmapSet.ID); refetchedBeatmapSet = beatmapManager.QueryBeatmapSet(s => s.ID == EditorBeatmap.BeatmapInfo.BeatmapSet.ID);
}); });
AddAssert("new beatmap persisted", () => AddAssert("new beatmap persisted", () =>
{ {
return refetchedBeatmap != null return refetchedBeatmap != null
&& refetchedBeatmap.DifficultyName == secondDifficultyName && refetchedBeatmap.DifficultyName == copyDifficultyName
&& refetchedBeatmapSet != null && refetchedBeatmapSet != null
&& refetchedBeatmapSet.PerformRead(s => s.Beatmaps.Count == 2 && s.Beatmaps.Any(b => b.DifficultyName == secondDifficultyName)); && refetchedBeatmapSet.PerformRead(s =>
s.Beatmaps.Count == 2
&& s.Beatmaps.Any(b => b.DifficultyName == originalDifficultyName)
&& s.Beatmaps.Any(b => b.DifficultyName == copyDifficultyName));
}); });
AddAssert("old beatmap file not deleted", () => refetchedBeatmapSet.AsNonNull().PerformRead(s => s.Files.Count == 2)); AddAssert("old beatmap file not deleted", () => refetchedBeatmapSet.AsNonNull().PerformRead(s => s.Files.Count == 2));
} }