h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-12 20:22:55 +08:00
Code Issues Releases Wiki Activity

Fix occasional test failures in TestSceneBetmapRecommendations

Browse Source 
The game was being constructed befor the API was setup, which could mean
depending on test execution ordering and speed, the recommendations
array would not be filled.

Easy to reproduce by `[Solo]`ing `TestCorrectStarRatingIsUsed`.

See https://github.com/ppy/osu/runs/28689915929#r0s0.
This commit is contained in:
Dean Herbert 2024-08-13 17:28:16 +09:00
parent 513a666847
commit 14a00621f8
No known key found for this signature in database
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapRecommendations.cs
View File

@ -31,8 +31,6 @@ namespace osu.Game.Tests.Visual.SongSelect
[SetUpSteps] [SetUpSteps]
public override void SetUpSteps() public override void SetUpSteps()
{ {
base.SetUpSteps();
AddStep("populate ruleset statistics", () => AddStep("populate ruleset statistics", () =>
{ {
Dictionary<string, UserStatistics> rulesetStatistics = new Dictionary<string, UserStatistics>(); Dictionary<string, UserStatistics> rulesetStatistics = new Dictionary<string, UserStatistics>();
@ -68,6 +66,8 @@ namespace osu.Game.Tests.Visual.SongSelect
return 0; return 0;
} }
} }
base.SetUpSteps();
} }
[Test] [Test]