From 144726e3c691aa2c0259cdae6e03f7d05759c8e5 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Fri, 9 Oct 2020 17:12:01 +0900
Subject: [PATCH] Better guard against taiko swells becoming strong

---
 .../Beatmaps/TaikoBeatmapConverter.cs              |  2 +-
 osu.Game.Rulesets.Taiko/Objects/Swell.cs           |  2 ++
 osu.Game.Rulesets.Taiko/Objects/TaikoHitObject.cs  | 14 +++++++++++++-
 3 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/osu.Game.Rulesets.Taiko/Beatmaps/TaikoBeatmapConverter.cs b/osu.Game.Rulesets.Taiko/Beatmaps/TaikoBeatmapConverter.cs
index ed7b8589ba..607eaf5dbd 100644
--- a/osu.Game.Rulesets.Taiko/Beatmaps/TaikoBeatmapConverter.cs
+++ b/osu.Game.Rulesets.Taiko/Beatmaps/TaikoBeatmapConverter.cs
@@ -65,7 +65,7 @@ namespace osu.Game.Rulesets.Taiko.Beatmaps
                 converted.HitObjects = converted.HitObjects.GroupBy(t => t.StartTime).Select(x =>
                 {
                     TaikoHitObject first = x.First();
-                    if (x.Skip(1).Any() && !(first is Swell))
+                    if (x.Skip(1).Any() && first.CanBeStrong)
                         first.IsStrong = true;
                     return first;
                 }).ToList();
diff --git a/osu.Game.Rulesets.Taiko/Objects/Swell.cs b/osu.Game.Rulesets.Taiko/Objects/Swell.cs
index eeae6e79f8..bf8b7bc178 100644
--- a/osu.Game.Rulesets.Taiko/Objects/Swell.cs
+++ b/osu.Game.Rulesets.Taiko/Objects/Swell.cs
@@ -17,6 +17,8 @@ namespace osu.Game.Rulesets.Taiko.Objects
             set => Duration = value - StartTime;
         }
 
+        public override bool CanBeStrong => false;
+
         public double Duration { get; set; }
 
         /// <summary>
diff --git a/osu.Game.Rulesets.Taiko/Objects/TaikoHitObject.cs b/osu.Game.Rulesets.Taiko/Objects/TaikoHitObject.cs
index 2922010001..d2c37d965c 100644
--- a/osu.Game.Rulesets.Taiko/Objects/TaikoHitObject.cs
+++ b/osu.Game.Rulesets.Taiko/Objects/TaikoHitObject.cs
@@ -1,6 +1,7 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using System;
 using System.Threading;
 using osu.Framework.Bindables;
 using osu.Game.Rulesets.Judgements;
@@ -30,6 +31,11 @@ namespace osu.Game.Rulesets.Taiko.Objects
 
         public readonly Bindable<bool> IsStrongBindable = new BindableBool();
 
+        /// <summary>
+        /// Whether this <see cref="TaikoHitObject"/> can be made a "strong" (large) hit.
+        /// </summary>
+        public virtual bool CanBeStrong => true;
+
         /// <summary>
         /// Whether this HitObject is a "strong" type.
         /// Strong hit objects give more points for hitting the hit object with both keys.
@@ -37,7 +43,13 @@ namespace osu.Game.Rulesets.Taiko.Objects
         public bool IsStrong
         {
             get => IsStrongBindable.Value;
-            set => IsStrongBindable.Value = value;
+            set
+            {
+                if (value && !CanBeStrong)
+                    throw new InvalidOperationException($"Object of type {GetType()} cannot be strong");
+
+                IsStrongBindable.Value = value;
+            }
         }
 
         protected override void CreateNestedHitObjects(CancellationToken cancellationToken)