From 13dcaf82ada9d3e1a96322c49a194da0652b525d Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Mon, 27 Jun 2022 16:50:07 +0900
Subject: [PATCH] Fix chat tests failing 1/10000 runs

https://github.com/ppy/osu/blob/31a447fda0532fcf15f8c8251ca890c533386492/osu.Game/Online/Chat/ChannelManager.cs#L412-L414

Sigh.
---
 osu.Game.Tests/Visual/Online/TestSceneChatOverlay.cs | 4 ++--
 osu.Game/Online/API/DummyAPIAccess.cs                | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/osu.Game.Tests/Visual/Online/TestSceneChatOverlay.cs b/osu.Game.Tests/Visual/Online/TestSceneChatOverlay.cs
index 1fb0195368..73bad6e631 100644
--- a/osu.Game.Tests/Visual/Online/TestSceneChatOverlay.cs
+++ b/osu.Game.Tests/Visual/Online/TestSceneChatOverlay.cs
@@ -549,7 +549,7 @@ namespace osu.Game.Tests.Visual.Online
 
         private Channel createPrivateChannel()
         {
-            int id = RNG.Next(0, 10000);
+            int id = RNG.Next(0, DummyAPIAccess.DUMMY_USER_ID - 1);
             return new Channel(new APIUser
             {
                 Id = id,
@@ -559,7 +559,7 @@ namespace osu.Game.Tests.Visual.Online
 
         private Channel createAnnounceChannel()
         {
-            int id = RNG.Next(0, 10000);
+            int id = RNG.Next(0, DummyAPIAccess.DUMMY_USER_ID - 1);
             return new Channel
             {
                 Name = $"Announce {id}",
diff --git a/osu.Game/Online/API/DummyAPIAccess.cs b/osu.Game/Online/API/DummyAPIAccess.cs
index 245760a00a..07d544260e 100644
--- a/osu.Game/Online/API/DummyAPIAccess.cs
+++ b/osu.Game/Online/API/DummyAPIAccess.cs
@@ -15,10 +15,12 @@ namespace osu.Game.Online.API
 {
     public class DummyAPIAccess : Component, IAPIProvider
     {
+        public const int DUMMY_USER_ID = 1001;
+
         public Bindable<APIUser> LocalUser { get; } = new Bindable<APIUser>(new APIUser
         {
             Username = @"Dummy",
-            Id = 1001,
+            Id = DUMMY_USER_ID,
         });
 
         public BindableList<APIUser> Friends { get; } = new BindableList<APIUser>();