h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-05 10:33:22 +08:00
Code Issues Releases Wiki Activity

Enable recommended rules for maintainability

Browse Source
This commit is contained in:
Huo Yaoyuan 2024-11-28 19:55:03 +08:00
parent cd9b5927eb
commit 13d7c6a2d8
5 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Directory.Build.props
View File

@ -25,6 +25,8 @@
<AnalysisModeDocumentation>Recommended</AnalysisModeDocumentation> <AnalysisModeDocumentation>Recommended</AnalysisModeDocumentation>
<AnalysisModeGlobalization>Recommended</AnalysisModeGlobalization> <AnalysisModeGlobalization>Recommended</AnalysisModeGlobalization>
<AnalysisModeInteroperability>Recommended</AnalysisModeInteroperability> <AnalysisModeInteroperability>Recommended</AnalysisModeInteroperability>
<AnalysisModeMaintainability>Recommended</AnalysisModeMaintainability>
<AnalysisModeNaming>Default</AnalysisModeNaming>
</PropertyGroup> </PropertyGroup>
<PropertyGroup Label="Documentation"> <PropertyGroup Label="Documentation">
<GenerateDocumentationFile>true</GenerateDocumentationFile> <GenerateDocumentationFile>true</GenerateDocumentationFile>

2
osu.Game/Online/API/Requests/Responses/APIKudosuHistory.cs
View File

@ -45,7 +45,9 @@ namespace osu.Game.Online.API.Requests.Responses
public KudosuAction Action; public KudosuAction Action;
#pragma warning disable CA1507 // Happens to name the same because of casing preference
[JsonProperty("action")] [JsonProperty("action")]
#pragma warning restore CA1507
private string action private string action
{ {
set set

2
osu.Game/Online/API/Requests/Responses/APIUserMostPlayedBeatmap.cs
View File

@ -15,7 +15,9 @@ namespace osu.Game.Online.API.Requests.Responses
[JsonProperty("count")] [JsonProperty("count")]
public int PlayCount { get; set; } public int PlayCount { get; set; }
#pragma warning disable CA1507 // Happens to name the same because of casing preference
[JsonProperty("beatmap")] [JsonProperty("beatmap")]
#pragma warning restore CA1507
private APIBeatmap beatmap { get; set; } private APIBeatmap beatmap { get; set; }
public APIBeatmap BeatmapInfo public APIBeatmap BeatmapInfo

2
osu.Game/Online/Notifications/WebSocket/Events/NewChatMessageData.cs
View File

@ -19,7 +19,9 @@ namespace osu.Game.Online.Notifications.WebSocket.Events
[JsonProperty(@"messages")] [JsonProperty(@"messages")]
public List<Message> Messages { get; set; } = null!; public List<Message> Messages { get; set; } = null!;
#pragma warning disable CA1507 // Happens to name the same because of casing preference
[JsonProperty(@"users")] [JsonProperty(@"users")]
#pragma warning restore CA1507
private List<APIUser> users { get; set; } = null!; private List<APIUser> users { get; set; } = null!;
[OnDeserialized] [OnDeserialized]

5
osu.Game/Utils/SpecialFunctions.cs
View File

@ -666,10 +666,7 @@ namespace osu.Game.Utils
{ {
// 2020-10-07 jbialogrodzki #730 Since this is public API we should probably // 2020-10-07 jbialogrodzki #730 Since this is public API we should probably
// handle null arguments? It doesn't seem to have been done consistently in this class though. // handle null arguments? It doesn't seem to have been done consistently in this class though.
if (coefficients == null) ArgumentNullException.ThrowIfNull(coefficients);
{
throw new ArgumentNullException(nameof(coefficients));
}
// 2020-10-07 jbialogrodzki #730 Zero polynomials need explicit handling. // 2020-10-07 jbialogrodzki #730 Zero polynomials need explicit handling.
// Without this check, we attempted to peek coefficients at negative indices! // Without this check, we attempted to peek coefficients at negative indices!