From 12e29f0bcc9f80c221c5e97693613c8ca4ba94de Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Thu, 25 Sep 2025 15:55:37 +0900 Subject: [PATCH] Attempt to fix flaky `TestGameplaySettingsDoesNotExpandWhenSkinOverlayPresent` See https://github.com/ppy/osu/pull/35118/checks?check_run_id=51202910556. --- .../Visual/Navigation/TestSceneSkinEditorNavigation.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/osu.Game.Tests/Visual/Navigation/TestSceneSkinEditorNavigation.cs b/osu.Game.Tests/Visual/Navigation/TestSceneSkinEditorNavigation.cs index 02b2db6e31..0e1fa63439 100644 --- a/osu.Game.Tests/Visual/Navigation/TestSceneSkinEditorNavigation.cs +++ b/osu.Game.Tests/Visual/Navigation/TestSceneSkinEditorNavigation.cs @@ -278,6 +278,8 @@ namespace osu.Game.Tests.Visual.Navigation { advanceToSongSelect(); openSkinEditor(); + AddUntilStep("skin editor visible", () => skinEditor.State.Value == Visibility.Visible); + AddStep("select autoplay", () => Game.SelectedMods.Value = new Mod[] { new OsuModAutoplay() }); AddStep("import beatmap", () => BeatmapImportHelper.LoadQuickOszIntoOsu(Game).WaitSafely()); AddUntilStep("wait for selected", () => !Game.Beatmap.IsDefault); @@ -290,8 +292,9 @@ namespace osu.Game.Tests.Visual.Navigation AddAssert("settings not visible", () => getPlayerSettingsOverlay().DrawWidth, () => Is.EqualTo(0)); toggleSkinEditor(); + AddUntilStep("skin editor hidden", () => skinEditor.State.Value == Visibility.Hidden); - AddStep("move cursor slightly", () => InputManager.MoveMouseTo(InputManager.ScreenSpaceDrawQuad.TopRight + new Vector2(1))); + AddStep("move cursor slightly", () => InputManager.MoveMouseTo(InputManager.ScreenSpaceDrawQuad.TopRight + new Vector2(2))); AddUntilStep("settings visible", () => getPlayerSettingsOverlay().DrawWidth, () => Is.GreaterThan(0)); AddStep("move cursor to right of screen too far", () => InputManager.MoveMouseTo(InputManager.ScreenSpaceDrawQuad.TopRight + new Vector2(10240, 0)));