From 0e6660da30584a04de86565f0517fc35c3d1f5bc Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Fri, 3 Sep 2021 16:57:25 +0900 Subject: [PATCH] Replace todo with permanent comment --- osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs b/osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs index 3a206cc63e..25fe6e4a30 100644 --- a/osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs +++ b/osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs @@ -203,7 +203,8 @@ namespace osu.Game.Beatmaps.Formats } } - // TODO: we need to pull out approach rate from EffectControlPoint and shove it in with difficulty points where necessary... + // In the future we may want to pull out approach rate changes from EffectPoints (and create DifficultyControlPoints to handle them). + // This requires special consideration due to precision mismatches (see implementation of LegacyDifficultyControlPoint). } foreach (var group in beatmap.ControlPointInfo.Groups)